From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <normalperson@yhbt.net>
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: 
X-Spam-Status: No, score=-2.6 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00,
 RP_MATCHES_RCVD shortcircuit=no autolearn=unavailable version=3.3.2
X-Original-To: meta@public-inbox.org
Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net
 (Postfix) with ESMTP id 77D291F73C for <meta@public-inbox.org>; Sat, 30 Jan
 2016 23:39:11 +0000 (UTC)
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/2] view: cleanup permalink Thread: header display
Date: Sat, 30 Jan 2016 23:39:03 +0000
Message-Id: <20160130233903.5559-3-e@80x24.org>
In-Reply-To: <20160130233903.5559-1-e@80x24.org>
References: <20160130233903.5559-1-e@80x24.org>
List-Id: <meta@public-inbox.org>

The word "skip" can be confusing.  Instead, spell out "scroll down"
for the user to read and only display that text when the thread
is sufficiently long.
---
 lib/PublicInbox/View.pm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index e72243b..88ab2d2 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -475,8 +475,11 @@ sub thread_inline {
 		return;
 	}
 
-	$$dst .= "~$nr messages (<a\nhref=\"#b\">skip</a> / " .
-		 $expand . ")\n";
+	$$dst .= "~$nr messages ($expand";
+	if ($nr > MAX_INLINE_QUOTED) {
+		$$dst .= qq! / <a\nhref="#b">[scroll down]</a>!;
+	}
+	$$dst .= ")\n";
 
 	my $subj = $srch->subject_path($cur->header('Subject'));
 	my $state = {
-- 
EW