From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] www: redirect with query string
Date: Sat, 2 Jan 2016 23:14:58 +0000 [thread overview]
Message-ID: <20160102231458.32217-1-e@80x24.org> (raw)
We use query strings for search and index pages, so
we should not drop them if somebody types a URL by hand
and omits the trailing slash.
---
lib/PublicInbox/WWW.pm | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lib/PublicInbox/WWW.pm b/lib/PublicInbox/WWW.pm
index ee414e8..b4c050b 100644
--- a/lib/PublicInbox/WWW.pm
+++ b/lib/PublicInbox/WWW.pm
@@ -358,15 +358,19 @@ sub r301 {
my ($ctx, $listname, $mid, $suffix) = @_;
my $cgi = $ctx->{cgi};
my $url;
+ my $qs;
if (ref($cgi) eq 'CGI') {
$url = $cgi->url(-base) . '/';
+ $qs = $cgi->query_string;
} else {
$url = $cgi->base->as_string;
+ $qs = $cgi->env->{QUERY_STRING};
}
$url .= $listname . '/';
$url .= (uri_escape_utf8($mid) . '/') if (defined $mid);
$url .= $suffix if (defined $suffix);
+ $url .= "?$qs" if $qs ne '';
[ 301,
[ Location => $url, 'Content-Type' => 'text/plain' ],
--
EW
reply other threads:[~2016-01-02 23:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160102231458.32217-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).