* [PATCH] view: remove "created" and "updated" noise words
@ 2015-11-18 1:43 Eric Wong
2015-11-18 20:56 ` [PATCH] view: further reduce size of attribution/timestamp Eric Wong
0 siblings, 1 reply; 2+ messages in thread
From: Eric Wong @ 2015-11-18 1:43 UTC (permalink / raw)
To: meta
They increase HTML size and add to visual noise without telling
enough useful information.
---
lib/PublicInbox/View.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 48c4553..ce97f61 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -861,13 +861,13 @@ sub dump_topics {
my $attr;
$ts = POSIX::strftime('%Y-%m-%d %H:%M', gmtime($ts));
if ($n == 1) {
- $attr = "created @ $ts UTC";
+ $attr = "@ $ts UTC";
$n = "";
} else {
# $n isn't the total number of posts on the topic,
# just the number of posts in the current results
# window, so leave it unlabeled
- $attr = "updated @ $ts UTC";
+ $attr = "@ $ts UTC";
$n = " ($n)";
}
if ($level == 0 || $attr ne $prev_attr) {
--
EW
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] view: further reduce size of attribution/timestamp
2015-11-18 1:43 [PATCH] view: remove "created" and "updated" noise words Eric Wong
@ 2015-11-18 20:56 ` Eric Wong
0 siblings, 0 replies; 2+ messages in thread
From: Eric Wong @ 2015-11-18 20:56 UTC (permalink / raw)
To: meta
The "by" on the message page and "-" in the index are
unnecessary and readers should have no trouble figuring out
what the attribution/timestamp line means.
---
lib/PublicInbox/View.pm | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index ce97f61..92fedd1 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -107,7 +107,7 @@ sub index_entry {
}
$rv .= "<td\nid=s$midx>" . PRE_WRAP;
$rv .= "<b\nid=\"$id\">$subj</b>\n";
- $rv .= "- by $from @ $ts UTC - ";
+ $rv .= "- $from @ $ts UTC - ";
$rv .= "<a\nhref=\"#s$next\">next</a>";
if ($prev >= 0) {
$rv .= "/<a\nhref=\"#s$prev\">prev</a>";
@@ -875,8 +875,7 @@ sub dump_topics {
qq(href="$mid/t.mbox.gz">mbox.gz</a>);
my $atom = qq(<a\nhref="$mid/t.atom">Atom</a>);
$pfx .= INDENT if $level > 0;
- $dst .= "$pfx- ". $attr . $n;
- $dst .= " - $mbox / $atom\n";
+ $dst .= $pfx . $attr . $n . " - $mbox / $atom\n";
$prev_attr = $attr;
}
}
--
EW
Did you mean this?
format-patch
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-18 20:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-18 1:43 [PATCH] view: remove "created" and "updated" noise words Eric Wong
2015-11-18 20:56 ` [PATCH] view: further reduce size of attribution/timestamp Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).