From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00 shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: meta@public-inbox.org Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 85A60201BF for ; Wed, 30 Sep 2015 21:00:30 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 03/12] nntp: reduce syscalls for LIST OVERVIEW.FMT Date: Wed, 30 Sep 2015 21:00:18 +0000 Message-Id: <20150930210027.30479-4-e@80x24.org> In-Reply-To: <20150930210027.30479-1-e@80x24.org> References: <20150930210027.30479-1-e@80x24.org> List-Id: No point in sending such a short, bounded response with multiple syscalls. --- lib/PublicInbox/NNTP.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm index faa7563..dc4227e 100644 --- a/lib/PublicInbox/NNTP.pm +++ b/lib/PublicInbox/NNTP.pm @@ -24,7 +24,7 @@ use constant { sub now () { clock_gettime(CLOCK_MONOTONIC) }; my @OVERVIEW = qw(Subject From Date Message-ID References Bytes Lines); -my %OVERVIEW = map { $_ => 1 } @OVERVIEW; +my $OVERVIEW_FMT = join(":\r\n", @OVERVIEW) . ":\r\n"; # disable commands with easy DoS potential: # LISTGROUP could get pretty bad, too... @@ -90,9 +90,9 @@ sub cmd_xgtitle ($;$) { '.' } -sub list_overview_fmt ($$) { +sub list_overview_fmt ($) { my ($self) = @_; - more($self, $_ . ':') foreach @OVERVIEW; + do_more($self, $OVERVIEW_FMT); } sub list_active ($;$) { -- EW