unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/8] nntp: consistently use 501 for unsupported LIST
Date: Fri, 25 Sep 2015 02:27:51 +0000	[thread overview]
Message-ID: <20150925022757.6915-3-e@80x24.org> (raw)
In-Reply-To: <20150925022757.6915-1-e@80x24.org>

This is required by RFC 3977, section 3.2.1
---
 lib/PublicInbox/NNTP.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index c2f9717..dd033e8 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -123,14 +123,14 @@ sub list_newsgroups ($;$) {
 	}
 }
 
-# LIST SUBSCRIPTIONS not supported
+# LIST SUBSCRIPTIONS, DISTRIB.PATS are not supported
 sub cmd_list ($;$$) {
 	my ($self, @args) = @_;
 	if (scalar @args) {
 		my $arg = shift @args;
 		$arg =~ tr/A-Z./a-z_/;
 		$arg = "list_$arg";
-		return '503 function not performed' if $DISABLED{$arg};
+		return r501 if $DISABLED{$arg};
 
 		$arg = eval {
 			no strict 'refs';
-- 
EW


  parent reply	other threads:[~2015-09-25  2:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-25  2:27 [PATCH 0/8] nntp: more fixes and tiny speedups Eric Wong
2015-09-25  2:27 ` [PATCH 1/8] nntp: HDR allows metadata prefixed with ':' Eric Wong
2015-09-25  2:27 ` Eric Wong [this message]
2015-09-25  2:27 ` [PATCH 3/8] searchidx: remove unused sub: next_doc_id Eric Wong
2015-09-25  2:27 ` [PATCH 4/8] nntp: do not repeat result on blocked write Eric Wong
2015-09-25  2:27 ` [PATCH 5/8] nntp: prefix FD on every log line Eric Wong
2015-09-25  2:27 ` [PATCH 6/8] git: signal-safety for pipe writes Eric Wong
2015-09-25  2:27 ` [PATCH 7/8] git: use fields for GitCatFile Eric Wong
2015-09-25  2:27 ` [PATCH 8/8] nntp: avoid signals for long responses Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150925022757.6915-3-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).