From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <normalperson@yhbt.net>
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: 
X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00,
 T_RP_MATCHES_RCVD shortcircuit=no autolearn=unavailable version=3.3.2
X-Original-To: meta@public-inbox.org
Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net
 (Postfix) with ESMTP id E4B861F7DE for <meta@public-inbox.org>; Sun, 13 Sep
 2015 23:35:25 +0000 (UTC)
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 3/4] view: do not show References unless a message has them
Date: Sun, 13 Sep 2015 23:35:21 +0000
Message-Id: <20150913233522.8343-4-e@80x24.org>
In-Reply-To: <20150913233522.8343-1-e@80x24.org>
References: <20150913233522.8343-1-e@80x24.org>
List-Id: <meta@public-inbox.org>

It's a waste of space and potentially confusing.
---
 lib/PublicInbox/View.pm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 2cda691..aaab3b2 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -434,7 +434,12 @@ sub headers_to_html_header {
 	$rv .= "(<a\nhref=\"${upfx}raw\">raw</a>)\n";
 	my $atom;
 	if ($srch) {
-		$rv .= "<a\nhref=\"${upfx}t/\">References: [expand]</a>\n";
+		if ($header_obj->header('In-Reply-To') ||
+		    $header_obj->header('References')) {
+			$rv .= "<a\nhref=\"${upfx}t/\">" .
+				"References: [expand]</a>\n";
+		}
+
 		$atom = qq{<link\nrel=alternate\ntitle="Atom feed"\n} .
 			qq!href="${upfx}t.atom"\ntype="application/atom+xml"/>!;
 	} else {
-- 
EW