unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] extmsg: add note about the deficiency of the implementation
Date: Sat, 5 Sep 2015 09:18:22 +0000	[thread overview]
Message-ID: <20150905091821.GA30527@dcvr.yhbt.net> (raw)
In-Reply-To: <20150905091457.GA27857@dcvr.yhbt.net>

ref: http://public-inbox.org/meta/20150905091457.GA27857@dcvr.yhbt.net/
---
 lib/PublicInbox/ExtMsg.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/PublicInbox/ExtMsg.pm b/lib/PublicInbox/ExtMsg.pm
index 243b6ba..77537c2 100644
--- a/lib/PublicInbox/ExtMsg.pm
+++ b/lib/PublicInbox/ExtMsg.pm
@@ -95,6 +95,8 @@ sub ext_msg {
 		unshift @pfx, { srch => $ctx->{srch}, url => $url };
 		foreach my $pfx (@pfx) {
 			my $srch = delete $pfx->{srch} or next;
+
+			# FIXME we may need a proper prefix trie here...
 			if (my $res = $srch->mid_prefix($mid)) {
 				$n_partial += scalar(@$res);
 				$pfx->{res} = $res;
-- 
EW


      reply	other threads:[~2015-09-05  9:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-05  9:01 [PATCH 0/6] another round of search updates Eric Wong
2015-09-05  9:01 ` [PATCH 1/6] searchview: factor out dump_mset subroutine Eric Wong
2015-09-05  9:01 ` [PATCH 2/6] search: use relevance as secondary sort by default Eric Wong
2015-09-05  9:01 ` [PATCH 3/6] searchview: error description for invalid queries Eric Wong
2015-09-05  9:01 ` [PATCH 4/6] search: note why we do not support FLAG_PURE_NOT Eric Wong
2015-09-05  9:01 ` [PATCH 5/6] search: tweak parsing for internal queries Eric Wong
2015-09-05  9:01 ` [PATCH 6/6] extmsg: fall back to partial Message-ID matching Eric Wong
2015-09-05  9:14   ` Eric Wong
2015-09-05  9:18     ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150905091821.GA30527@dcvr.yhbt.net \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).