unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
* [PATCH] thread: workaround for another Mail::Thread bug
@ 2015-08-18  2:09 Eric Wong
  2015-08-18  2:15 ` [PATCH] thread: another workaround for a " Eric Wong
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Wong @ 2015-08-18  2:09 UTC (permalink / raw)
  To: meta

Yay for monkey patching!

ref: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=795913
ref: https://rt.cpan.org/Ticket/Display.html?id=106498
---
 lib/PublicInbox/Thread.pm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/lib/PublicInbox/Thread.pm b/lib/PublicInbox/Thread.pm
index 58efb8d..92404fa 100644
--- a/lib/PublicInbox/Thread.pm
+++ b/lib/PublicInbox/Thread.pm
@@ -1,5 +1,10 @@
 # subclass Mail::Thread and use this to workaround a memory leak
 # Based on the patch in: https://rt.cpan.org/Public/Bug/Display.html?id=22817
+#
+# Additionally, workaround for a bug where $walk->topmost returns undef:
+# - http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=795913
+# - https://rt.cpan.org/Ticket/Display.html?id=106498
+#
 # License differs from the rest of public-inbox (but is compatible):
 # This library is free software; you can redistribute it and/or modify
 # it under the same terms as Perl itself.
@@ -33,4 +38,19 @@ use base qw(Mail::Thread::Container);
 use Scalar::Util qw(weaken);
 sub parent { @_ == 2 ? weaken($_[0]->{parent} = $_[1]) : $_[0]->{parent} }
 
+sub topmost {
+	$_[0]->SUPER::topmost || PublicInbox::Thread::CPANRTBug106498->new;
+}
+
+# ref:
+# - http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=795913
+# - https://rt.cpan.org/Ticket/Display.html?id=106498
+package PublicInbox::Thread::CPANRTBug106498;
+use strict;
+use warnings;
+
+sub new { bless {}, $_[0] }
+
+sub simple_subject {}
+
 1;
-- 
EW

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] thread: another workaround for a Mail::Thread bug
  2015-08-18  2:09 [PATCH] thread: workaround for another Mail::Thread bug Eric Wong
@ 2015-08-18  2:15 ` Eric Wong
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Wong @ 2015-08-18  2:15 UTC (permalink / raw)
  To: meta

Oops, that's was the subject I actually pushed to
git://80x24.org/public-inbox :x

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-08-18  2:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-18  2:09 [PATCH] thread: workaround for another Mail::Thread bug Eric Wong
2015-08-18  2:15 ` [PATCH] thread: another workaround for a " Eric Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).