unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] view: show quotes in index if parent is too old
Date: Sun, 31 Aug 2014 02:55:20 +0000	[thread overview]
Message-ID: <20140831025520.GA6601@dcvr.yhbt.net> (raw)

It's helpful to show context if a message does not
appear on the current index page.
---
 lib/PublicInbox/View.pm | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index d1bb935..c1a5fbb 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -76,6 +76,13 @@ sub index_entry {
 
 	$rv .= "$pfx<a name=\"$name\"><b>$subj</b> $from - $ts</a>\n\n";
 
+	my $irp = $header_obj->header_raw('In-Reply-To');
+	my ($anchor_idx, $anchor);
+	if (defined $irp) {
+		$anchor_idx = anchor_for($irp);
+		$anchor = $seen->{$anchor_idx};
+	}
+
 	# scan through all parts, looking for displayable text
 	$mime->walk_parts(sub {
 		my ($part) = @_;
@@ -91,8 +98,11 @@ sub index_entry {
 
 		my $s = ascii_html($enc->decode($part->body));
 
-		# drop quotes, including the "so-and-so wrote:" line
-		$s =~ s/(?:^[^\n]*:\s*\n)?(?:^&gt;[^\n]*\n)+(?:^\s*\n)?//mg;
+		if (defined $anchor) {
+			# drop quotes, including the "so-and-so wrote:" line
+			$s =~ s/(?:^[^\n]*:\s*\n)?
+			       (?:^&gt;[^\n]*\n)+(?:^\s*\n)?//mgx;
+		}
 
 		# Drop signatures
 		$s =~ s/^-- \n.*\z//ms;
@@ -119,10 +129,7 @@ sub index_entry {
 	$rv .= "<a\nhref=\"$txt\">raw</a> ";
 	$rv .= html_footer($mime, 0);
 
-	my $irp = $header_obj->header_raw('In-Reply-To');
 	if (defined $irp) {
-		my $anchor_idx = anchor_for($irp);
-		my $anchor = $seen->{$anchor_idx};
 		unless (defined $anchor) {
 			my $v = PublicInbox::Hval->new_msgid($irp);
 			my $html = $v->as_html;
-- 
EW

                 reply	other threads:[~2014-08-31  2:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140831025520.GA6601@dcvr.yhbt.net \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).