From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 7/9] view: thread view expands focused message
Date: Fri, 4 Sep 2015 08:58:57 +0000 [thread overview]
Message-ID: <1441357139-23879-8-git-send-email-e@80x24.org> (raw)
In-Reply-To: <1441357139-23879-1-git-send-email-e@80x24.org>
Non-top-level messages still deserve to be shown in full
if they're the message in the URL.
---
lib/PublicInbox/View.pm | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 4e800c6..ea31364 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -85,7 +85,7 @@ sub index_entry {
$from = PublicInbox::Hval->new_oneline($from)->as_html;
$subj = PublicInbox::Hval->new_oneline($subj)->as_html;
my $more = 'permalink';
- my $root_anchor = $state->{root_anchor};
+ my $root_anchor = $state->{root_anchor} || '';
my $path = $root_anchor ? '../../' : '';
my $href = $mid->as_href;
my $irt = in_reply_to($header_obj);
@@ -95,7 +95,7 @@ sub index_entry {
my $t = $ctx->{flat} ? 'T' : 't';
$subj = "<a\nhref=\"${path}$href/$t/#u\">$subj</a>";
}
- if ($root_anchor && $root_anchor eq $id) {
+ if ($root_anchor eq $id) {
$subj = "<u\nid=\"u\">$subj</u>";
}
@@ -116,8 +116,8 @@ sub index_entry {
my ($fhref, $more_ref);
my $mhref = "${path}$href/";
- # show full messages at level == 0 in threaded view
- if ($level > 0 || ($ctx->{flat} && $root_anchor ne $id)) {
+ # show full message if it's our root message
+ if ($root_anchor ne $id) {
$fhref = "${path}$href/f/";
$more_ref = \$more;
}
--
EW
next prev parent reply other threads:[~2015-09-04 8:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 8:58 [PATCH 0/9] another round of updates Eric Wong
2015-09-04 8:58 ` [PATCH 1/9] view: eliminate redundant [threaded|flat] link Eric Wong
2015-09-04 8:58 ` [PATCH 2/9] view: one line for thread subjects Eric Wong
2015-09-04 8:58 ` [PATCH 3/9] view: adjust spacing and indentation of index threads Eric Wong
2015-09-04 8:58 ` [PATCH 4/9] view: add missing newline to inline dump Eric Wong
2015-09-04 8:58 ` [PATCH 5/9] view: reduce redundant attributions in permalink refs Eric Wong
2015-09-04 8:58 ` [PATCH 6/9] view: indentation adjustments for collapsed headers Eric Wong
2015-09-04 8:58 ` Eric Wong [this message]
2015-09-04 8:58 ` [PATCH 8/9] www: extra redirects for the '/'-challenged Eric Wong
2015-09-04 8:58 ` [PATCH 9/9] view: fix broken link to ghost fallback Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441357139-23879-8-git-send-email-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).