From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.6 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, RP_MATCHES_RCVD,URIBL_BLOCKED shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: meta@public-inbox.org Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id E893B1FD1F for ; Sun, 30 Aug 2015 01:54:47 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] view: remove "threadlink" from thread view Date: Sun, 30 Aug 2015 01:54:47 +0000 Message-Id: <1440899687-15047-1-git-send-email-e@80x24.org> List-Id: We're already inside the thread, and our thread summary inside /m/$MESSAGE_ID/ is already sufficient got navigate back to the /t/$MESSAGE_ID/ page. So I think it's sufficient to keep the /t/$MESSAGE_ID/ page lighter with fewer links and avoid introducing strange terminology. In contrast, "permalink" is relatively well-known and not an alien term to readers: https://en.wikipedia.org/wiki/Permalink --- lib/PublicInbox/View.pm | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index 7cac785..3ee6790 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -74,13 +74,10 @@ sub index_entry { my $path = $root_anchor ? '../../' : ''; my $href = $mid->as_href; my $irt = $header_obj->header('In-Reply-To'); - my ($anchor_idx, $anchor, $t_anchor); + my ($anchor_idx, $anchor); if (defined $irt) { $anchor_idx = anchor_for($irt); $anchor = $seen->{$anchor_idx}; - $t_anchor = T_ANCHOR; - } else { - $t_anchor = ''; } if ($srch) { $subj = "$subj"; @@ -134,11 +131,6 @@ sub index_entry { $rv .= " parent"; } - if ($srch) { - $rv .= " " . - "threadlink"; - } - $fh->write($rv .= ''); } -- EW