* [PATCH] view: remove "threadlink" from thread view
@ 2015-08-30 1:54 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2015-08-30 1:54 UTC (permalink / raw)
To: meta
We're already inside the thread, and our thread summary inside
/m/$MESSAGE_ID/ is already sufficient got navigate back to the
/t/$MESSAGE_ID/ page. So I think it's sufficient to keep the
/t/$MESSAGE_ID/ page lighter with fewer links and avoid
introducing strange terminology.
In contrast, "permalink" is relatively well-known and
not an alien term to readers:
https://en.wikipedia.org/wiki/Permalink
---
lib/PublicInbox/View.pm | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 7cac785..3ee6790 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -74,13 +74,10 @@ sub index_entry {
my $path = $root_anchor ? '../../' : '';
my $href = $mid->as_href;
my $irt = $header_obj->header('In-Reply-To');
- my ($anchor_idx, $anchor, $t_anchor);
+ my ($anchor_idx, $anchor);
if (defined $irt) {
$anchor_idx = anchor_for($irt);
$anchor = $seen->{$anchor_idx};
- $t_anchor = T_ANCHOR;
- } else {
- $t_anchor = '';
}
if ($srch) {
$subj = "<a\nhref=\"${path}t/$href/#u\">$subj</a>";
@@ -134,11 +131,6 @@ sub index_entry {
$rv .= " <a\nhref=\"$anchor\">parent</a>";
}
- if ($srch) {
- $rv .= " <a\nhref=\"${path}t/$href/$t_anchor\">" .
- "threadlink</a>";
- }
-
$fh->write($rv .= '</pre></td></tr></table>');
}
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-08-30 1:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-30 1:54 [PATCH] view: remove "threadlink" from thread view Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).