From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.5 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, RP_MATCHES_RCVD shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: meta@public-inbox.org Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id C52E61FD1F for ; Sun, 30 Aug 2015 01:48:05 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] view: remove "threadlink" name in per-message view Date: Sun, 30 Aug 2015 01:48:05 +0000 Message-Id: <1440899285-10518-1-git-send-email-e@80x24.org> List-Id: It's a strange word and I'm not quite comfortable with it in a message view. Instead, use a descriptive link for the thread headers. --- lib/PublicInbox/View.pm | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index 660447d..7cac785 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -390,12 +390,14 @@ sub thread_inline { my $mid = mid_compress(mid_clean($cur->header('Message-ID'))); my $res = $srch->get_thread($mid); my $nr = $res->{total}; + if ($nr <= 1) { - $$dst .= "[only message in thread]\n"; + $$dst .= "\n[no followups, yet]\n"; return; } - $$dst .= "roughly $nr messages in thread:\n"; + $$dst .= "\n\n~$nr messages in thread: ". + "(expand)\n"; my $subj = $srch->subject_path($cur->header('Subject')); my $state = { seen => { $subj => 1 }, @@ -473,11 +475,6 @@ sub html_footer { my $srch = $ctx->{srch} if $ctx; my $idx = $standalone ? " index" : ''; if ($idx && $srch) { - $mid = mid_compress(mid_clean($mid)); - my $t_anchor = defined $irt ? T_ANCHOR : ''; - $irt = $mime->header('In-Reply-To'); - $idx = " ". - "threadlink$idx\n\n"; my $next = thread_inline(\$idx, $ctx, $mime); if (defined $irt) { $irt = PublicInbox::Hval->new_msgid($irt); -- EW