* [PATCH] search: only sort by relevance if requested
@ 2015-08-25 1:35 Eric Wong
2015-08-25 1:43 ` [PATCH v2] " Eric Wong
0 siblings, 1 reply; 2+ messages in thread
From: Eric Wong @ 2015-08-25 1:35 UTC (permalink / raw)
To: meta
Many of our internal search queries do not care about relevance,
but is used for proper thread displays.
---
lib/PublicInbox/Search.pm | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/Search.pm b/lib/PublicInbox/Search.pm
index c61d4cf..440fcef 100644
--- a/lib/PublicInbox/Search.pm
+++ b/lib/PublicInbox/Search.pm
@@ -117,7 +117,11 @@ sub do_enquire {
$query = Search::Xapian::Query->new(OP_AND, $query, $mail_query);
$enquire->set_query($query);
- $enquire->set_sort_by_relevance_then_value(TS, 0);
+ if ($opts->{relevance}) {
+ $enquire->set_sort_by_relevance_then_value(TS, 0);
+ } else {
+ $enquire->set_sort_by_value(TS, 0);
+ }
$opts ||= {};
my $offset = $opts->{offset} || 0;
my $limit = $opts->{limit} || 50;
--
EW
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH v2] search: only sort by relevance if requested
2015-08-25 1:35 [PATCH] search: only sort by relevance if requested Eric Wong
@ 2015-08-25 1:43 ` Eric Wong
0 siblings, 0 replies; 2+ messages in thread
From: Eric Wong @ 2015-08-25 1:43 UTC (permalink / raw)
To: meta
Many of our internal search queries do not care about relevance,
but is used for proper thread displays.
---
v2: set relevance when doing a regular query
lib/PublicInbox/Search.pm | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/Search.pm b/lib/PublicInbox/Search.pm
index c61d4cf..d780878 100644
--- a/lib/PublicInbox/Search.pm
+++ b/lib/PublicInbox/Search.pm
@@ -76,6 +76,8 @@ sub query {
my ($self, $query_string, $opts) = @_;
my $query = $self->qp->parse_query($query_string, QP_FLAGS);
+ $opts ||= {};
+ $opts->{relevance} = 1;
$self->do_enquire($query, $opts);
}
@@ -117,7 +119,11 @@ sub do_enquire {
$query = Search::Xapian::Query->new(OP_AND, $query, $mail_query);
$enquire->set_query($query);
- $enquire->set_sort_by_relevance_then_value(TS, 0);
+ if ($opts->{relevance}) {
+ $enquire->set_sort_by_relevance_then_value(TS, 0);
+ } else {
+ $enquire->set_sort_by_value(TS, 0);
+ }
$opts ||= {};
my $offset = $opts->{offset} || 0;
my $limit = $opts->{limit} || 50;
--
EW
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-25 1:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-25 1:35 [PATCH] search: only sort by relevance if requested Eric Wong
2015-08-25 1:43 ` [PATCH v2] " Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).