[PATCH] view: cleaner killing of leading/trailing whitespace

[PATCH] view: cleaner killing of leading/trailing whitespace

[Eric Wong]

No point in wasting bytes even if gets compressed over
the wire, it'll use more memory when rendering on the
client.
---
 lib/PublicInbox/View.pm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 660a112..e1632b5 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -142,14 +142,17 @@ sub index_walk {
 	# Drop signatures
 	$s =~ s/^-- \n.*\z//ms and $$more = 'more...';
 
-	# kill any leading or trailing whitespace
-	$s =~ s/\A\s+//s;
+	# kill any leading or trailing whitespace lines
+	$s =~ s/^[ \t]$//sgm;
 	$s =~ s/\s+\z//s;
 
 	if (length $s) {
 		# add prefix:
 		$s =~ s/^/$pfx/sgm;
 
+		# kill per-line trailing whitespace
+		$s =~ s/[ \t]+$//sgm;
+
 		$rv .= $s . "\n";
 	}
 	$rv;
-- 
EW

[PATCH] view: kill leading empty lines correctly

[Eric Wong]

Was too sleepy to be coding last night :x
---
 lib/PublicInbox/View.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index e1632b5..6e4d178 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -143,7 +143,7 @@ sub index_walk {
 	$s =~ s/^-- \n.*\z//ms and $$more = 'more...';
 
 	# kill any leading or trailing whitespace lines
-	$s =~ s/^[ \t]$//sgm;
+	$s =~ s/^\s*$//sgm;
 	$s =~ s/\s+\z//s;
 
 	if (length $s) {
-- 
EW