* [PATCH] view: cleaner killing of leading/trailing whitespace
@ 2015-08-16 9:19 Eric Wong
2015-08-16 20:52 ` [PATCH] view: kill leading empty lines correctly Eric Wong
0 siblings, 1 reply; 2+ messages in thread
From: Eric Wong @ 2015-08-16 9:19 UTC (permalink / raw)
To: meta; +Cc: Eric Wong
No point in wasting bytes even if gets compressed over
the wire, it'll use more memory when rendering on the
client.
---
lib/PublicInbox/View.pm | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 660a112..e1632b5 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -142,14 +142,17 @@ sub index_walk {
# Drop signatures
$s =~ s/^-- \n.*\z//ms and $$more = 'more...';
- # kill any leading or trailing whitespace
- $s =~ s/\A\s+//s;
+ # kill any leading or trailing whitespace lines
+ $s =~ s/^[ \t]$//sgm;
$s =~ s/\s+\z//s;
if (length $s) {
# add prefix:
$s =~ s/^/$pfx/sgm;
+ # kill per-line trailing whitespace
+ $s =~ s/[ \t]+$//sgm;
+
$rv .= $s . "\n";
}
$rv;
--
EW
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] view: kill leading empty lines correctly
2015-08-16 9:19 [PATCH] view: cleaner killing of leading/trailing whitespace Eric Wong
@ 2015-08-16 20:52 ` Eric Wong
0 siblings, 0 replies; 2+ messages in thread
From: Eric Wong @ 2015-08-16 20:52 UTC (permalink / raw)
To: meta
Was too sleepy to be coding last night :x
---
lib/PublicInbox/View.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index e1632b5..6e4d178 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -143,7 +143,7 @@ sub index_walk {
$s =~ s/^-- \n.*\z//ms and $$more = 'more...';
# kill any leading or trailing whitespace lines
- $s =~ s/^[ \t]$//sgm;
+ $s =~ s/^\s*$//sgm;
$s =~ s/\s+\z//s;
if (length $s) {
--
EW
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-16 20:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-16 9:19 [PATCH] view: cleaner killing of leading/trailing whitespace Eric Wong
2015-08-16 20:52 ` [PATCH] view: kill leading empty lines correctly Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).