From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] view: make the thread index less claustrophobic
Date: Sat, 4 Oct 2014 03:06:54 +0000 [thread overview]
Message-ID: <1412392014-6459-2-git-send-email-e@80x24.org> (raw)
At the cost of some vertical whitespace.
More bikeshedding...
---
lib/PublicInbox/View.pm | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 3860d6e..d64aca4 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -68,7 +68,7 @@ sub index_entry {
my $pfx = (' ' x $level);
my $ts = $mime->header('X-PI-Date');
- my $fmt = '%H:%M';
+ my $fmt = '%H:%M UTC';
if ($now > ($ts + (365 * 24 * 60 * 60))) {
# doesn't have to be exactly 1 year
$fmt = '%Y/%m/%d';
@@ -79,11 +79,15 @@ sub index_entry {
$rv .= "$pfx<a\nname=\"$name\"></a>" .
"<a\nname=\"s$midx\"></a>" .
- "<b>$subj</b> $from - $ts\n" .
+ "<b>$subj</b>\n" .
"$pfx<a\nhref=\"#s$next\">next</a>";
- $rv .= " <a\nhref=\"#s$prev\">prev</a>" if $prev >= 0;
- $rv .= "\n";
+ if ($prev >= 0) {
+ $rv .= "/<a\nhref=\"#s$prev\">prev</a>";
+ } else {
+ $rv .= ' ';
+ }
+ $rv .= " by $from @ $ts\n\n";
my $irp = $header_obj->header_raw('In-Reply-To');
my ($anchor_idx, $anchor);
@@ -129,7 +133,7 @@ sub index_entry {
++$part_nr;
});
- $rv .= "$pfx<a\nhref=\"$mhref\">$more</a> ";
+ $rv .= "\n$pfx<a\nhref=\"$mhref\">$more</a> ";
my $txt = "m/$href.txt";
$rv .= "<a\nhref=\"$txt\">raw</a> ";
$rv .= html_footer($mime, 0);
--
EW
reply other threads:[~2014-10-04 3:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412392014-6459-2-git-send-email-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).