From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.4 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, RP_MATCHES_RCVD shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: meta@public-inbox.org Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id B8AEA1F45C; Mon, 15 Sep 2014 21:01:49 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Cc: Eric Wong Subject: [PATCH 2/3] index: drop signatures from nested output Date: Mon, 15 Sep 2014 21:01:37 +0000 Message-Id: <1410814898-8628-2-git-send-email-e@80x24.org> X-Mailer: git-send-email 2.1.0.243.g30d45f7 In-Reply-To: <1410814898-8628-1-git-send-email-e@80x24.org> References: <1410814898-8628-1-git-send-email-e@80x24.org> List-Id: We have a less-ambiguous "more..." link nowadays if somebody wants to see the full message. --- lib/PublicInbox/View.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index ce63f7d..028c276 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -109,13 +109,13 @@ sub index_entry { my $s = add_text_body_short($enc, $part, $part_nr, $fhref); - # keep signatures for now? They shold usually be short, - # and sometimes footnotes/"P.S." appear there. - # drop the remainder of git patches, they're usually better # to review when the full message is viewed $s =~ s!^---\n.*\z!!ms and $more = 'more...'; + # Drop signatures + $s =~ s/^-- \n.*\z//ms and $more = 'more...'; + # kill any leading or trailing whitespace $s =~ s/\A\s+//s; $s =~ s/\s+\z//s; -- EW