From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Cc: Eric Wong <e@80x24.org>
Subject: [PATCH 2/3] index: drop signatures from nested output
Date: Mon, 15 Sep 2014 21:01:37 +0000 [thread overview]
Message-ID: <1410814898-8628-2-git-send-email-e@80x24.org> (raw)
In-Reply-To: <1410814898-8628-1-git-send-email-e@80x24.org>
We have a less-ambiguous "more..." link nowadays if somebody
wants to see the full message.
---
lib/PublicInbox/View.pm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index ce63f7d..028c276 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -109,13 +109,13 @@ sub index_entry {
my $s = add_text_body_short($enc, $part, $part_nr, $fhref);
- # keep signatures for now? They shold usually be short,
- # and sometimes footnotes/"P.S." appear there.
-
# drop the remainder of git patches, they're usually better
# to review when the full message is viewed
$s =~ s!^---\n.*\z!!ms and $more = 'more...';
+ # Drop signatures
+ $s =~ s/^-- \n.*\z//ms and $more = 'more...';
+
# kill any leading or trailing whitespace
$s =~ s/\A\s+//s;
$s =~ s/\s+\z//s;
--
EW
next prev parent reply other threads:[~2014-09-15 21:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 21:01 [PATCH 1/3] hval: fixup bad line endings in HTML output Eric Wong
2014-09-15 21:01 ` Eric Wong [this message]
2014-09-15 21:01 ` [PATCH 3/3] filter: ensure CRs do not show up in lynx conversions Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410814898-8628-2-git-send-email-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).