From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Ihor Radchenko <yantar92@gmail.com>,
"Basil L. Contovounesios" <contovob@tcd.ie>,
emacs-devel@gnu.org
Subject: Re: master 48aacbf292 2/2: Make many seldom-used generalized variables obsolete
Date: Sat, 10 Sep 2022 10:21:40 -0400 [thread overview]
Message-ID: <jwvbkrngvru.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <877d2bohgm.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 10 Sep 2022 08:45:45 +0200")
Lars Ingebrigtsen [2022-09-10 08:45:45] wrote:
> Ihor Radchenko <yantar92@gmail.com> writes:
>> This commit also obsoleted a number of generalized variables used by
>> Org. In particular, `buffer-substring', and `buffer-string'.
>>
>> While it is indeed possible to set buffer contents without the above
>> variables, it cannot (AFAIK) be done using a single function call.
>> Would it be possible to provide a function replacement for setting a
>> buffer text in the whole buffer/buffer region?
>
> "Setting a buffer text" is something that is un-Emacsey, in my opinion.
> That is, (setf (buffer-substring ...) ...) is pretending that we're
> operating on some object, but instead we're altering global (buffer)
> state.
Ihor doesn't specifically ask to keep the generalized variable, but to
offer some straightforward replacement.
> Just delete and insert instead
That's indeed what `cl--set-buffer-substring` (the workhorse of the
current gv-expander) does, but it's not ideal: it should insert first
and then delete, so as to better preserve markers.
For this reason, I do think we should provide a function to do that.
>> Also, obsoleting `buffer-file-name' revealed one potentially concerning
>> fact about generalized variables. The expansion of `buffer-file-name'
>> setter, `set-visited-file-name' "... also renames the buffer to
>> correspond to the new file." I am now wondering if there are any
>> non-obvious side effects when using other generalized variables - there
>> is (AFAIK) no documentation about what exactly various setters for
>> generalized variables do other than occasional paragraph in the manual.
>
> All these obsoleted generalised variables had non-obvious side effects,
> which is why I obsoleted them.
+1
Stefan
next prev parent reply other threads:[~2022-09-10 14:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166111278304.2846.13033924580993120733@vcs2.savannah.gnu.org>
[not found] ` <20220821201303.AD1E6C0088A@vcs2.savannah.gnu.org>
2022-08-25 10:39 ` master 48aacbf292 2/2: Make many seldom-used generalized variables obsolete Basil L. Contovounesios
2022-08-25 12:41 ` Lars Ingebrigtsen
2022-09-10 5:17 ` Ihor Radchenko
2022-09-10 6:45 ` Lars Ingebrigtsen
2022-09-10 7:02 ` Ihor Radchenko
2022-09-10 7:07 ` Lars Ingebrigtsen
2022-09-10 14:25 ` Stefan Monnier
2022-09-11 9:33 ` Ihor Radchenko
2022-09-10 14:21 ` Stefan Monnier [this message]
2022-09-11 17:11 ` Sean Whitton
2022-09-11 17:57 ` Lars Ingebrigtsen
2022-09-18 23:10 ` Jonas Bernoulli
2022-09-19 6:00 ` Lars Ingebrigtsen
2022-09-19 10:01 ` Jonas Bernoulli
2022-09-19 11:38 ` Augusto Stoffel
2022-09-19 12:22 ` Lars Ingebrigtsen
2022-09-19 12:35 ` Augusto Stoffel
2022-09-19 12:37 ` Lars Ingebrigtsen
2022-09-19 12:51 ` Augusto Stoffel
2022-09-19 12:21 ` Lars Ingebrigtsen
2022-09-19 12:46 ` Stefan Monnier
2022-09-19 12:54 ` Po Lu
2022-09-19 13:05 ` Lars Ingebrigtsen
2022-09-19 12:46 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvbkrngvru.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=yantar92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).