From: Liliana Marie Prikler <liliana.prikler@ist.tugraz.at>
To: Olivier Dion <olivier.dion@polymtl.ca>, gwl-devel@gnu.org
Subject: Re: GWL 0.5 fails with plain packages
Date: Sat, 30 Jul 2022 19:03:16 +0200 [thread overview]
Message-ID: <d54930df8dbfbe6ad7f3da3b1ff1f472df6a36f8.camel@ist.tugraz.at> (raw)
In-Reply-To: <877d3w2ai5.fsf@laura>
Am Freitag, dem 29.07.2022 um 11:40 -0400 schrieb Olivier Dion:
> Please try the following patch:
> --8<---------------cut here---------------start------------->8---
> diff --git a/gwl/processes.scm b/gwl/processes.scm
> index 2452d1f..4207f51 100644
> --- a/gwl/processes.scm
> +++ b/gwl/processes.scm
> @@ -197,12 +197,21 @@
> ((and (? string?) spec)
> (lookup-package spec))
> ((and (? valid-package?) pkg)
> + (set! (package-output pkg) "out")
> + pkg)
> + (((? valid-package? pkg) (? string? output))
> + (set! (package-output pkg) output)
Looking at the code for handling plain packages, that'd probably work,
but it raises more questions. Like "why is package-ouput a object-
property?" and "wouldn't this break if someone needed two different
outputs of the same package in a process or even anywhere in the
workflow?"
next prev parent reply other threads:[~2022-07-30 17:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 11:45 GWL 0.5 fails with plain packages Liliana Marie Prikler
2022-07-29 15:40 ` Olivier Dion via
2022-07-30 17:03 ` Liliana Marie Prikler [this message]
2022-07-30 17:04 ` Liliana Marie Prikler
2022-07-30 18:47 ` Olivier Dion via
2022-07-31 8:16 ` Liliana Marie Prikler
2022-07-31 13:33 ` Olivier Dion via
2022-07-31 14:35 ` Olivier Dion via
2022-07-31 21:17 ` Olivier Dion via
2022-08-01 7:21 ` Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.guixwl.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d54930df8dbfbe6ad7f3da3b1ff1f472df6a36f8.camel@ist.tugraz.at \
--to=liliana.prikler@ist.tugraz.at \
--cc=gwl-devel@gnu.org \
--cc=olivier.dion@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).