From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id cCL7A9QFnmJOJAEAbAwnHQ (envelope-from ) for ; Mon, 06 Jun 2022 15:49:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id gHnzA9QFnmIb+AAA9RJhRA (envelope-from ) for ; Mon, 06 Jun 2022 15:49:08 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B11783BEDA for ; Mon, 6 Jun 2022 15:49:03 +0200 (CEST) Received: from localhost ([::1]:35944 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nyD6M-0008EG-J5 for larch@yhetil.org; Mon, 06 Jun 2022 09:49:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyCjf-0000Bm-OZ for gwl-devel@gnu.org; Mon, 06 Jun 2022 09:25:35 -0400 Received: from smtp.polymtl.ca ([132.207.4.11]:42036) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyCjd-0002w5-6f for gwl-devel@gnu.org; Mon, 06 Jun 2022 09:25:34 -0400 Received: from localhost (modemcable094.169-200-24.mc.videotron.ca [24.200.169.94]) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 256DPNXZ021902; Mon, 6 Jun 2022 09:25:28 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 256DPNXZ021902 To: Ricardo Wurmus Cc: gwl-devel@gnu.org Subject: Re: [PATCH] gwl/ui: Check for log-events configuration In-Reply-To: <87k09u3wto.fsf@elephly.net> References: <20220603183203.11092-1-olivier.dion@polymtl.ca> <875ylg5v60.fsf@elephly.net> <874k10xy4t.fsf@laura> <87k09u3wto.fsf@elephly.net> Date: Mon, 06 Jun 2022 09:25:23 -0400 Message-ID: <87y1y9x6t8.fsf@laura> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Poly-FromMTA: (modemcable094.169-200-24.mc.videotron.ca [24.200.169.94]) at Mon, 6 Jun 2022 13:25:23 +0000 Received-SPF: pass client-ip=132.207.4.11; envelope-from=olivier.dion@polymtl.ca; helo=smtp.polymtl.ca X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: gwl-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gwl-devel-bounces+larch=yhetil.org@gnu.org Sender: "gwl-devel" Reply-to: Olivier Dion From: Olivier Dion via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654523343; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=7B7a1v3rmhK1uruWxJhP5v1n1EWuyVH5WpNrSHFPRUE=; b=D7pf2TrUfNK+qwTOfg+7osBmhtwuinhhnfTVvI5N0wXwe/+OAYZl7Zbrka3oLTuUwEaGgO tG0wVFmwfAgef6pCZHtzhREE8KSuuQ6oN7Y0JkTNeg6TXS26KgnuwpnvdT1DBSuffkWDt9 gU33F23sl4Dmt+0fDYy8NU0KY4tAx1tFm9mdbdm2aI0MuMb7xEjs1Xi/canbbR75EAnlc1 lnjbBUkBk+6fYehDpPQMyr0LEf2EZS1I+wl0TaW2tl+Rte52N9pMItFnIJ8bh3ZwV0Yo8V uxzt1eaoYClU8xLbshHSklMFltoxl6a4Jq2tV0rX1PhhePnJc2dwEX8otq5O0Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654523343; a=rsa-sha256; cv=none; b=OnlAZYKKDu617b8CqiN8KCLl6wbbYxEYmIN7FN+oBA50I69ScxjtdB8UrUQMqpb2b8GYhS jFZk0ATQwmjinlMAwliWtmbdNG5jnPuqPd1WNu1ngv9PNoobWhH9i35Ps/zUbNZ7bXLmb/ 8IeMOZNz/NJyl0v6DUdYEtOwCxJDrEWaO+mX1ll7UV5ShPA8k+ywvXC2OynsnVFSB5jlgV FAid3tK6rkkFGy2qCPiSbKhPy6hlnrw66zo2h09VM2oX5wpiCPkNU6CyX0zLUW96UWefV9 coWx/SohONDMA10EqZGa4t6X/tJmhwYnIKB2IFHNH5oOjwa6r39mH4tD9B4Lbw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "gwl-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="gwl-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.81 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "gwl-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="gwl-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B11783BEDA X-Spam-Score: -3.81 X-Migadu-Scanner: scn0.migadu.com X-TUID: mT15ak4rrW6h On Mon, 06 Jun 2022, Ricardo Wurmus wrote: > Olivier Dion writes: > >> On Sat, 04 Jun 2022, Ricardo Wurmus wrote: >>> Olivier Dion writes: >>> >>>> Some GWL sub-commands such as `graph' do not accept a log event config= uration. >>>> This results in returning `#f' from `(%config 'log-events)' >>> >>> I don=E2=80=99t understand how this leads to a problem. Do any of the = features >>> of =E2=80=9Cgraph=E2=80=9D use =E2=80=9Clog-event=E2=80=9D? >> >> Yes. `load-workflow' -> `load-workflow*' -> `load*' -> `log-event 'info >> "Loading workflow file"'. > > I see. > > Does it make sense to support the --log-events option on =E2=80=9Cgraph= =E2=80=9D? Or > should we just work around it in the log-event procedure? I think that in all cases, the default of `(%config 'log-events)' should be '() like you proposed. In that way, if new commands are added in the future, this undesired behavior won't re-surface. As for adding the `--log-events` option to the `graph' command. The thing is that the output of the graph is printed on stdout. Adding log-event would add an extra step in order to separate the logs from the desired output. Thus, I think that if we do that, we also need to add a `--output=3DDOT' option for redirecting the graph's output away from the terminal. WDY? --=20 Olivier Dion oldiob.dev