From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kyle Meyer <kyle@kyleam.com>
Subject: Some doc/examples files incompatible with latest update
Date: Wed, 12 Jun 2019 00:03:32 -0400
Message-ID: <87v9xbih63.fsf@kyleam.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
To: gwl-devel@gnu.org
List-ID: <gwl-devel.gnu.org>

Playing around with the latest updates (specifically on commit 08ccba0),
I'm unable to run some of the examples.  For instance, if I try

,----
| doc/examples $ ../../pre-inst-env guix workflow -f --run=3Dsimple.scm
| workflow: The "restrictions" field is deprecated.  Use "processes" to spe=
cify process dependencies.
| Backtrace:
|           11 (apply-smob/1 #<catch-closure 1c8e900>)
| In ice-9/boot-9.scm:
|     705:2 10 (call-with-prompt _ _ #<procedure default-prompt-handle=E2=
=80=A6>)
| In ice-9/eval.scm:
|     619:8  9 (_ #(#(#<directory (guile-user) 1cbe140>)))
| In guix/ui.scm:
|   1747:12  8 (run-guix-command _ . _)
| In ice-9/eval.scm:
|     619:8  7 (_ #(#(#(#<directory (guix scripts workflow) 209=E2=80=A6> =
=E2=80=A6)) =E2=80=A6))
|     619:8  6 (_ #(#(#(#<directory (gwl workflows) 21e33c0>) #<=E2=80=A6> =
=E2=80=A6) =E2=80=A6))
|    626:19  5 (_ #(#(#(#<directory (gwl workflows) 21e33c0>) #<=E2=80=A6> =
=E2=80=A6) =E2=80=A6))
|    293:34  4 (_ #(#(#(#<directory (gwl workflows) 21e33c0>) #<=E2=80=A6> =
=E2=80=A6) =E2=80=A6))
|    196:35  3 (_ #(#(#(#<directory (gwl workflows) 21e33c0>) #<=E2=80=A6> =
=E2=80=A6) =E2=80=A6))
|    293:34  2 (_ #(#(#<directory (gwl workflows) 21e33c0>) #<unspec=E2=80=
=A6>))
| In oop/goops.scm:
|    1492:4  1 (cache-miss #<unspecified>)
| In unknown file:
|            0 (scm-error goops-error #f "No applicable method for ~S=E2=80=
=A6" =E2=80=A6)
|=20
| ERROR: In procedure scm-error:
| No applicable method for #<<accessor> workflow-processes* (1)> in call
| (workflow-processes* #<unspecified>)
`----

The warning on the first line seems to be spurious---simple.scm doesn't
use "restrictions"---and I'd guess that warning was introduced by
8e76f22 (workflows: Implement <workflow> type with GOOPS).

Anyway the error seems to be related to the expectation that, for
--run=3DFILE, FILE will evaluate to a workflow.  I must admit I couldn't
glean that from the above error, but I see that d676e60 adjusted some
workflows in this manner.  Doing the same for simple.scm resolves the
above issue, and a similar fix works for simple.scm's wisp counterpart.
Patch below, assuming doing that is the correct fix.

I'm still not able to get extended-example-workflow.scm running despite
d676e60 already adjusting it.  I've debugged it a bit, and there seems
to be a few separate issues, but I didn't get it working and I'm running
out of time at the moment to properly write it up, so I'll leave it be
for now.

-- >8 --
Subject: [PATCH] doc: Update simple examples for d676e60.

* doc/examples/simple-wisp.w:
* doc/examples/simple.scm: Evaluate to a workflow, as expected since
d676e60.
---
 doc/examples/simple-wisp.w | 2 ++
 doc/examples/simple.scm    | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/doc/examples/simple-wisp.w b/doc/examples/simple-wisp.w
index c168881..4ab2495 100644
--- a/doc/examples/simple-wisp.w
+++ b/doc/examples/simple-wisp.w
@@ -26,3 +26,5 @@ workflow: simple-wisp
         eat-veges -> greet
         sleep     -> eat-fruit eat-veges
         bye       -> sleep
+
+. simple-wisp
diff --git a/doc/examples/simple.scm b/doc/examples/simple.scm
index fc1e3b4..e747c81 100644
--- a/doc/examples/simple.scm
+++ b/doc/examples/simple.scm
@@ -37,3 +37,5 @@ (define-public simple
              (eat-veges -> greet)
              (sleep     -> eat-fruit eat-veges)
              (bye       -> sleep))))))
+
+simple
--=20
2.22.0