From: Kyle Meyer <kyle@kyleam.com>
To: gwl-devel@gnu.org
Subject: Some doc/examples files incompatible with latest update
Date: Wed, 12 Jun 2019 00:03:32 -0400 [thread overview]
Message-ID: <87v9xbih63.fsf@kyleam.com> (raw)
Playing around with the latest updates (specifically on commit 08ccba0),
I'm unable to run some of the examples. For instance, if I try
,----
| doc/examples $ ../../pre-inst-env guix workflow -f --run=simple.scm
| workflow: The "restrictions" field is deprecated. Use "processes" to specify process dependencies.
| Backtrace:
| 11 (apply-smob/1 #<catch-closure 1c8e900>)
| In ice-9/boot-9.scm:
| 705:2 10 (call-with-prompt _ _ #<procedure default-prompt-handle…>)
| In ice-9/eval.scm:
| 619:8 9 (_ #(#(#<directory (guile-user) 1cbe140>)))
| In guix/ui.scm:
| 1747:12 8 (run-guix-command _ . _)
| In ice-9/eval.scm:
| 619:8 7 (_ #(#(#(#<directory (guix scripts workflow) 209…> …)) …))
| 619:8 6 (_ #(#(#(#<directory (gwl workflows) 21e33c0>) #<…> …) …))
| 626:19 5 (_ #(#(#(#<directory (gwl workflows) 21e33c0>) #<…> …) …))
| 293:34 4 (_ #(#(#(#<directory (gwl workflows) 21e33c0>) #<…> …) …))
| 196:35 3 (_ #(#(#(#<directory (gwl workflows) 21e33c0>) #<…> …) …))
| 293:34 2 (_ #(#(#<directory (gwl workflows) 21e33c0>) #<unspec…>))
| In oop/goops.scm:
| 1492:4 1 (cache-miss #<unspecified>)
| In unknown file:
| 0 (scm-error goops-error #f "No applicable method for ~S…" …)
|
| ERROR: In procedure scm-error:
| No applicable method for #<<accessor> workflow-processes* (1)> in call
| (workflow-processes* #<unspecified>)
`----
The warning on the first line seems to be spurious---simple.scm doesn't
use "restrictions"---and I'd guess that warning was introduced by
8e76f22 (workflows: Implement <workflow> type with GOOPS).
Anyway the error seems to be related to the expectation that, for
--run=FILE, FILE will evaluate to a workflow. I must admit I couldn't
glean that from the above error, but I see that d676e60 adjusted some
workflows in this manner. Doing the same for simple.scm resolves the
above issue, and a similar fix works for simple.scm's wisp counterpart.
Patch below, assuming doing that is the correct fix.
I'm still not able to get extended-example-workflow.scm running despite
d676e60 already adjusting it. I've debugged it a bit, and there seems
to be a few separate issues, but I didn't get it working and I'm running
out of time at the moment to properly write it up, so I'll leave it be
for now.
-- >8 --
Subject: [PATCH] doc: Update simple examples for d676e60.
* doc/examples/simple-wisp.w:
* doc/examples/simple.scm: Evaluate to a workflow, as expected since
d676e60.
---
doc/examples/simple-wisp.w | 2 ++
doc/examples/simple.scm | 2 ++
2 files changed, 4 insertions(+)
diff --git a/doc/examples/simple-wisp.w b/doc/examples/simple-wisp.w
index c168881..4ab2495 100644
--- a/doc/examples/simple-wisp.w
+++ b/doc/examples/simple-wisp.w
@@ -26,3 +26,5 @@ workflow: simple-wisp
eat-veges -> greet
sleep -> eat-fruit eat-veges
bye -> sleep
+
+. simple-wisp
diff --git a/doc/examples/simple.scm b/doc/examples/simple.scm
index fc1e3b4..e747c81 100644
--- a/doc/examples/simple.scm
+++ b/doc/examples/simple.scm
@@ -37,3 +37,5 @@ (define-public simple
(eat-veges -> greet)
(sleep -> eat-fruit eat-veges)
(bye -> sleep))))))
+
+simple
--
2.22.0
next reply other threads:[~2019-06-12 4:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 4:03 Kyle Meyer [this message]
2019-06-12 9:41 ` Some doc/examples files incompatible with latest update Ricardo Wurmus
2019-06-12 13:37 ` Kyle Meyer
2019-06-14 13:52 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.guixwl.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9xbih63.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=gwl-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).