From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id OGguNqAImmKxMgAAbAwnHQ (envelope-from ) for ; Fri, 03 Jun 2022 15:12:00 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id oMgpNqAImmK//wAAauVa8A (envelope-from ) for ; Fri, 03 Jun 2022 15:12:00 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 90A853FDF5 for ; Fri, 3 Jun 2022 15:12:00 +0200 (CEST) Received: from localhost ([::1]:35302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nx75r-00043d-7Z for larch@yhetil.org; Fri, 03 Jun 2022 09:11:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35838) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nx75f-00041L-Da for gwl-devel@gnu.org; Fri, 03 Jun 2022 09:11:49 -0400 Received: from smtp.polymtl.ca ([132.207.4.11]:40122) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nx75c-000315-6r for gwl-devel@gnu.org; Fri, 03 Jun 2022 09:11:46 -0400 Received: from localhost (modemcable094.169-200-24.mc.videotron.ca [24.200.169.94]) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 253DBZWj017091; Fri, 3 Jun 2022 09:11:41 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 253DBZWj017091 To: Ricardo Wurmus Cc: gwl-devel@gnu.org Subject: Re: [PATCH v2] tests/examples: Add running of workflow examples In-Reply-To: <87y1yew1wd.fsf@elephly.net> References: <20220429175500.17176-1-olivier.dion@polymtl.ca> <20220507164703.27219-1-olivier.dion@polymtl.ca> <87y1yew1wd.fsf@elephly.net> Date: Fri, 03 Jun 2022 09:11:35 -0400 Message-ID: <87v8thao3c.fsf@laura> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Poly-FromMTA: (modemcable094.169-200-24.mc.videotron.ca [24.200.169.94]) at Fri, 3 Jun 2022 13:11:35 +0000 Received-SPF: pass client-ip=132.207.4.11; envelope-from=olivier.dion@polymtl.ca; helo=smtp.polymtl.ca X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: gwl-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gwl-devel-bounces+larch=yhetil.org@gnu.org Sender: "gwl-devel" Reply-to: Olivier Dion From: Olivier Dion via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654261920; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=bAIl6nyW9zUEKSDcgAC+ufISPTI0cBTPJdeAs1o4l3Y=; b=aM3AR8fQRVLc3AKKfi36t0I37gBintyw+DC2xa7gDNxvvUkMBPqzBFgwkAsN52KU8uxaYp 8ECwN6icvLzmpCNC1a6ZflEyviD0iGi62fNHx0xxCky0UWIWpUy/lYslPWtAFPRPJAA8OS XvYcGIEK1SnixYnNVbtF+wXQY0UVoljZRhDeB1MusrlrbH9mYdKKpmMK2TmOV1AeBFjrU8 d+DVTQ9FYzswcx98MwgX+k8JYB+QWo0uOAp1v1+oBmv+MtlAXOV+G0iVu4t1pdvmwrI7Er H0pGMurnivBLIgl60W+hPypiRutsWhwbnGC5tQb97kw38vzUxhV4YJG2O4B2kw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654261920; a=rsa-sha256; cv=none; b=enf+WLdqR6PuAFPiFop9NOc8SIB3xIceCRuZ5f2HSMCQNBuLObudBUuc5cawVOa4EVS8gE e8ezLI3SSmBTn1rXlMaCXb5PdIuCKcly9A0y7MfII0oh8r1dS0RxE+N1eWpcOjczoqx6Ef nHzObMqJ0+3gxENnuYIuiK2HkrVb3qtn3gPiuAxaWPRX20hUmr69Deanha5OJOa1P2pNbt lEyxg0gyN2knjwmGW4YEI5xHwr7OzHg4BVnjN8FNawZ2Y79KT7eDCXZWSbwfomEYXm/Qva AFDfuCHWTmeXvjYh+PVt9xgmOtB9YCJ8gYKy7YM90v6jJv2reQnVu7osI/etwA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "gwl-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="gwl-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.02 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "gwl-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="gwl-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 90A853FDF5 X-Spam-Score: -3.02 X-Migadu-Scanner: scn0.migadu.com X-TUID: hw08r0+wDwZj On Fri, 03 Jun 2022, Ricardo Wurmus wrote: > Olivier Dion writes: > >> End to end testing of pre-defined scenarios are a good way to check for >> regression. >> >> Here we introduce testing of some examples available in the documentatio= n. That >> way, we're sure that new users should be able to run them without proble= ms. >> >> Each scenario is a different test and is run in a different temporary >> directory which get destroyed if the scenario succeeded. > > Thank you for this patch. I applied it. I also added an environment > variable check to allow us to skip these integration tests, e.g. when > running the tests inside of a Guix build container (where we don=E2=80=99= t have > access to Guix). What about skipping the group instead of running the tests? --8<---------------cut here---------------start------------->8--- (when (getenv "GWL_SKIP_INTEGRATION_TESTS") (test-skip "full-examples")) (test-group "full-examples" (test-example "simple.scm") (test-example "simple-wisp.w") ;; ... ) --8<---------------cut here---------------end--------------->8--- --=20 Olivier Dion oldiob.dev