Re: Some doc/examples files incompatible with latest update

[Kyle Meyer <kyle@kyleam.com>]

Ricardo Wurmus <rekado@elephly.net> writes:

>> | ERROR: In procedure scm-error:
>> | No applicable method for #<<accessor> workflow-processes* (1)> in call
>> | (workflow-processes* #<unspecified>)
>
> “load-workflow” now prints an understandable error message when the file
> it loads does not evaluate to a workflow.

Thanks.

Should simple-wisp.w also be updated to evaluate to a workflow
(something along the lines of the patch I included with my first email)?

,----
| doc/examples $ ../../pre-inst-env guix workflow -f --run=simple-wisp.w
| Compiling simple-wisp.w...OK
| File `simple-wisp.w' does not evaluate to a workflow value.
`----

>> The warning on the first line seems to be spurious---simple.scm doesn't
>> use "restrictions"---and I'd guess that warning was introduced by
>> 8e76f22 (workflows: Implement <workflow> type with GOOPS).
>
> That was indeed a side-effect of initializing the “restrictions” field
> to #F.  This is now fixed.

Great, thanks.

>> I'm still not able to get extended-example-workflow.scm running despite
>> d676e60 already adjusting it.  I've debugged it a bit, and there seems
>> to be a few separate issues, but I didn't get it working and I'm running
>> out of time at the moment to properly write it up, so I'll leave it be
>> for now.
>
> The problem appeared to be the conflicting import of “zip” from (gnu
> packages compression) and (srfi srfi-1), which is loaded by default.
> It’s also fixed now.

Right, that was one thing.  Another thing I hit into is the assumption
that the workflow is executed from a particular location, which is
presumably an interaction between loading extended-example-workflow.scm
and its `(include "example-workflow.scm")'.

I first tried from withing doc/examples/:

,----
| doc/examples $ ../../pre-inst-env guix workflow -f --run=extended-example-workflow.scm
| failed to load 'extended-example-workflow.scm': No such file or directory
|  
|            8 (apply-smob/1 #<catch-closure 1155240>)
| In ice-9/boot-9.scm:
|     705:2  7 (call-with-prompt _ _ #<procedure default-prompt-handle…>)
| In ice-9/eval.scm:
|     619:8  6 (_ #(#(#<directory (guile-user) 11ea140>)))
| In guix/ui.scm:
|   1747:12  5 (run-guix-command _ . _)
| In guix/scripts/workflow.scm:
|    118:17  4 (guix-workflow . _)
| In gwl/utils.scm:
|    103:16  3 (load-workflow "extended-example-workflow.scm")
| In ice-9/boot-9.scm:
|     829:9  2 (catch _ _ #<procedure 7fa7046af488 at gwl/utils.scm:2…> …)
|    2312:4  1 (save-module-excursion _)
| In gwl/utils.scm:
|    281:11  0 (_)
| Error: (system-error open-file ~A: ~S (No such file or directory doc/examples/example-workflow.scm) (2))
| File `extended-example-workflow.scm' does not evaluate to a workflow value.
`----

But I had to go up to the top-level directory to get it to work.

,----
| <gwl root> $ ./pre-inst-env guix workflow -f --run=doc/examples/extended-example-workflow.scm
| Executing: /bin/sh -c /gnu/store/g5wkzwgbfgma76ycn3mwd2xmph37clhm-create-file-one.txt 
| Executing: /bin/sh -c /gnu/store/w481dn7lqafdsns416n833z4wlh1qayg-create-file-two.txt 
| Executing: /bin/sh -c /gnu/store/w9dn1h1rhladkfk4fyyjyman33vc2n44-create-file-three.txt 
| Executing: /bin/sh -c /gnu/store/z36ibjk85i4ya1liwcgq4ilng31midhn-compress-file-one.txt 
| Executing: /bin/sh -c /gnu/store/dgf3izpqq07a6zqacyq6qh5qfnk9azhz-compress-file-two.txt 
| Executing: /bin/sh -c /gnu/store/6mm7alimsdm5mdjv6gv713p2b3bhqhdi-compress-file-three.txt 
| Executing: /bin/sh -c /gnu/store/yji5pjkn9dqv9sgi0jvl1dxz4f6brcjb-list-file-one.txt.gz 
| Executing: /bin/sh -c /gnu/store/7d7bkih2qj03gs36b7nzjvf8calw65xn-list-file-two.txt.gz 
| Executing: /bin/sh -c /gnu/store/fvyb0awbfd6jmj74hjf2agm0wq6i8866-list-file-three.txt.gz
`----