From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id aOloLFDYnWJEUQAAbAwnHQ (envelope-from ) for ; Mon, 06 Jun 2022 12:34:56 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id YBpoLFDYnWKewQAA9RJhRA (envelope-from ) for ; Mon, 06 Jun 2022 12:34:56 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EE6AC16F0F for ; Mon, 6 Jun 2022 12:34:55 +0200 (CEST) Received: from localhost ([::1]:42678 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nyA4T-0000zq-Qc for larch@yhetil.org; Mon, 06 Jun 2022 06:34:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyA3g-0000yl-1F for gwl-devel@gnu.org; Mon, 06 Jun 2022 06:34:07 -0400 Received: from sender4-of-o50.zoho.com ([136.143.188.50]:21037) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyA3e-0007hJ-9A for gwl-devel@gnu.org; Mon, 06 Jun 2022 06:34:03 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1654511640; cv=none; d=zohomail.com; s=zohoarc; b=iCapxM4tIWsZkEAG8ARZYjRLRqLHJtb2d2Z39AreIwIXUG9ShTWpMxeMCGNbK/HqL9M/JW6bgosD+evV+LIZaSd47Kr7HXXoTFO8Kr3hZP6NifS48lGErxOZ+BwsL0cb/UKKRqnBi1RrVPjVRBFaqqAQzvjUsU6NXbqe50QiHCA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654511640; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=LeCwhAot0L3vNoAnuOdMPxfXwIzDphCgotX/AW0Q9io=; b=NklP4oojXiOhyjSJkSWsSy/eyLzsS7jepbAYOrUBKgJfolWctYERCp/6XMdKh0Lj5NsNFsYCRXHoajguntC5V3RTs12oWquhqTjAXTl1+C6v5BlSkpgtAtMHNUY/+APLzBUKHzoM+R9rpbRlrq+GtIfQSjdspNDwU1gLe6SSdc4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1654511640; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=LeCwhAot0L3vNoAnuOdMPxfXwIzDphCgotX/AW0Q9io=; b=cqa5Z/E43ISfSDfVbB14mp6vmxdpQG/tBcr+cSTPHNCDf6nXKH5sa6oBd81hZENh ZLZqUOch3z3bpkONRP/CQaqC9P7noto5XtlK8k2b46fpTMidXHe5XdUlnYQo5RBjKba MLujQUJaV4exaWDIeKmkPdfrVEWzcdR2Kbi+3Is4= Received: from localhost (251-108-142-46.pool.kielnet.net [46.142.108.251]) by mx.zohomail.com with SMTPS id 1654511638108269.8027969775692; Mon, 6 Jun 2022 03:33:58 -0700 (PDT) References: <20220603183203.11092-1-olivier.dion@polymtl.ca> <875ylg5v60.fsf@elephly.net> <874k10xy4t.fsf@laura> User-agent: mu4e 1.6.10; emacs 28.1 From: Ricardo Wurmus To: Olivier Dion Cc: gwl-devel@gnu.org Subject: Re: [PATCH] gwl/ui: Check for log-events configuration Date: Mon, 06 Jun 2022 12:32:46 +0200 In-reply-to: <874k10xy4t.fsf@laura> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Message-ID: <87k09u3wto.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.188.50; envelope-from=rekado@elephly.net; helo=sender4-of-o50.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: gwl-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gwl-devel-bounces+larch=yhetil.org@gnu.org Sender: "gwl-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654511696; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=LeCwhAot0L3vNoAnuOdMPxfXwIzDphCgotX/AW0Q9io=; b=dS5OKYf0rYM9qBxlVPEk5y8ZASjvWYG29XvgXfqJJgQluBg6VoO0hpd9ZEa7MN1qprzPL1 IIPwFV8Di0t+vPNT1jw0EYhkLRraAbj7aYG2LuSIBN7Qd7SKry43QRWbrlClFQ4Xa9tIxL grgZgOxEvoYm8ntiHY8zF36PBuSea3xbGWf31jpmSQdotWd8E+mqrXp9OF7l78qjD0Q/WR olYNF7ZmBrgwp1ULdXkBVwWJrHX1SwyfEjEgQ+CFjDZFJoEfwC15Z4TFW0diPOI5Q9p2Ka d6SoeR1UE6MJKf9KWf6Gw+c6RqwAZhCuUKWiXyI3Vkd2xmWtB49Q7R+D+sdS8g== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1654511696; a=rsa-sha256; cv=pass; b=Hs+o5cQjcPHtkO//tLM/SElMAbV6szr9ByKangmTBYEeHsZFKi609XVgqOEJ9Lc/EZACqm jw29oW9hFOteEzitSx34SLfRoVscM17mURsqXjKhQCP7fSircFW99hnMsPAi8Fxp7yhoFa M5uElMNdIGS0U3p9wuQelnf6Y0hH/ZzgQLwWr2INpgM585IOpn3oPhkhpC6U1DTgrXFFL9 o10UFe6lSAEt6vvt8yBDednx6ViP2UZ7BsqFNo7mXuAJthZBaprCD0qTeXFKbwwlCRoD9b kwmEOH5K5Z4UASXjvBKWiRys/LzGIxrIgQbyDcLOiBrw+GNREbWGdd3so/hrgw== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=pass header.d=elephly.net header.s=zoho header.b="cqa5Z/E4"; arc=pass ("zohomail.com:s=zohoarc:i=1"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of "gwl-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="gwl-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.61 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=elephly.net header.s=zoho header.b="cqa5Z/E4"; arc=pass ("zohomail.com:s=zohoarc:i=1"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of "gwl-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="gwl-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: EE6AC16F0F X-Spam-Score: -6.61 X-Migadu-Scanner: scn0.migadu.com X-TUID: 32IaQDqWgsgo Olivier Dion writes: > On Sat, 04 Jun 2022, Ricardo Wurmus wrote: >> Olivier Dion writes: >> >>> Some GWL sub-commands such as `graph' do not accept a log event configu= ration. >>> This results in returning `#f' from `(%config 'log-events)' >> >> I don=E2=80=99t understand how this leads to a problem. Do any of the f= eatures >> of =E2=80=9Cgraph=E2=80=9D use =E2=80=9Clog-event=E2=80=9D? > > Yes. `load-workflow' -> `load-workflow*' -> `load*' -> `log-event 'info > "Loading workflow file"'. I see. Does it make sense to support the --log-events option on =E2=80=9Cgraph=E2= =80=9D? Or should we just work around it in the log-event procedure? >> Generally, I=E2=80=99d prefer to give =E2=80=9Clog-events=E2=80=9D a bet= ter default. I can=E2=80=99t >> imagine a situation where #F (rather than the empty list) would be >> appropriate. > > The empty list would be a more sane choice I agree. I'll send a v2 with > this change. Also, the `print?` predicate could be memoize with `mlambda= '? Yes, =E2=80=9Cprint?=E2=80=9D could me memoized. --=20 Ricardo