From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uPoWDsEtimJQBQEAbAwnHQ (envelope-from ) for ; Sun, 22 May 2022 14:34:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id WLEWDcEtimJSNgAAG6o9tA (envelope-from ) for ; Sun, 22 May 2022 14:34:09 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 89F0432C4C for ; Sun, 22 May 2022 14:34:08 +0200 (CEST) Received: from localhost ([::1]:40822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nskmd-0004sE-5e for larch@yhetil.org; Sun, 22 May 2022 08:34:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56758) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nskmb-0004oV-BS for gwl-devel@gnu.org; Sun, 22 May 2022 08:34:05 -0400 Received: from smtp.polymtl.ca ([132.207.4.11]:42179) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nskmY-0003zx-VF for gwl-devel@gnu.org; Sun, 22 May 2022 08:34:04 -0400 Received: from localhost (modemcable094.169-200-24.mc.videotron.ca [24.200.169.94]) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 24MCXkCB018455 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 22 May 2022 08:33:53 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 24MCXkCB018455 To: Ricardo Wurmus Cc: gwl-devel@gnu.org Subject: Re: [PATCH v3 1/1] packages: Support for full Guix specification In-Reply-To: <87h75ijbr7.fsf@elephly.net> References: <20220422184359.7929-1-olivier.dion@polymtl.ca> <20220429180247.17830-1-olivier.dion@polymtl.ca> <20220429180247.17830-2-olivier.dion@polymtl.ca> <87h75ijbr7.fsf@elephly.net> Date: Sun, 22 May 2022 08:33:46 -0400 Message-ID: <87h75hhhlh.fsf@laura> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Poly-FromMTA: (modemcable094.169-200-24.mc.videotron.ca [24.200.169.94]) at Sun, 22 May 2022 12:33:46 +0000 Received-SPF: pass client-ip=132.207.4.11; envelope-from=olivier.dion@polymtl.ca; helo=smtp.polymtl.ca X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: gwl-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gwl-devel-bounces+larch=yhetil.org@gnu.org Sender: "gwl-devel" Reply-to: Olivier Dion From: Olivier Dion via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653222848; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=7wcPxcTeZKC4UlD0WuqQe1mL1NEhrnG9v/xsQz+fHEA=; b=DHMxh4ork/z/Jv5RMvPuZX8Eu0YKhpqNT2nduW1KvE3v7h8S2+PV/Q/JQWQd7cyhOU2bRH vddu5iSQMWo8/MLGbXH2A95b9jgayEay81Odrc5yA8B/Ckfm4iZ1kTjTMl+s4AmDKHKmWw GVFhKBDv0/kaeiWqwSGaG3W3YU3S/r6hleN1wXmuTuNqz6aWHJizrApMf0aYGhXJnO7wTL AUThTe3MpDPxeMcATagLcqF3M2IY7XlrslJ4kzXVu1NMDsLGy9Z+R63vyTdwc/Mq+uBu16 fK3946xutvM6zbTwgWpevtIJgF0zs86PQT/0rHh8ZcZPz/sHmSFXDewjPBBk1w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653222848; a=rsa-sha256; cv=none; b=BqdwbXCsxkWZTXR29YFqgE569S9zXa30KrfV0Jq4CDZBuzJhkalLSo9Qfb2U3+MSIBbVyA L4g3CIZ0tmfBuMfm2Cpzn+0VK4Gafk6rjkG27nxEhIx/XiJQaFqt2HxkK9a5V0GYZe+Djo ftdijsHvQdjFmUTaDkoKjdWq8s321/K/5LfZt4t4sxQ0LrFvZmEw2W5J6NmL0YgLfvLlcd 9dXz1Ose1jn+DE0NFcSJIt7RmNGOuPsKV1WIyhI3uSJwaMZ2WWHkeirDPLN+hBqI8uhQ81 MqDNAgUQxOrfYqn0jatAAu2zNB0yUrAgdwlk4VOoRt2Nx7fA6Owf4krsyuX4Xg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "gwl-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="gwl-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.65 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "gwl-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="gwl-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 89F0432C4C X-Spam-Score: -2.65 X-Migadu-Scanner: scn0.migadu.com X-TUID: ltLYSeUuG3wd On Sun, 22 May 2022, Ricardo Wurmus wrote: > Hi Olivier, > > thanks for the new patch and my apologies for the delay! > > It looks fine, but I can=E2=80=99t help but feel a little confused about = what > variables are actual package values and what are wrappers. Sometimes we > have a variable called =E2=80=9Cpackages=E2=80=9D, but it=E2=80=99s seemi= ngly always going to be > package wrappers, so we map =E2=80=9Cpackage-unwrap=E2=80=9D. > > I wonder if there=E2=80=99s a way to hide this machinery somewhat. On th= e other > hand, =E2=80=9Cpackage-unwrap=E2=80=9D is a no-op for actual packages, so= it doesn=E2=80=99t > really matter. Hi. I've think of a way to accomplish this without introducing anything ad-hoc. You will see in my next patch. Basically, I use object properties to mark a package with its output. By doing so, we only need to change the code that actually need the package's output, that is the call to `packages->manifest'. The rest of the code simply manipulates a package as usual. I think it's technique called data layering and is awesome! --=20 Olivier Dion oldiob.dev