From: Ricardo Wurmus <rekado@elephly.net>
To: Olivier Dion <olivier.dion@polymtl.ca>
Cc: gwl-devel@gnu.org
Subject: Re: [PATCH v4] packages: Support for full Guix specification
Date: Mon, 23 May 2022 23:02:53 +0200 [thread overview]
Message-ID: <87ee0khs9s.fsf@elephly.net> (raw)
In-Reply-To: <20220522123844.23527-1-olivier.dion@polymtl.ca>
Hi Olivier,
thank you for the updated patch! Using object properties is a neat
idea.
> @@ -73,11 +77,18 @@
>
> (define (lookup-package specification)
> (log-event 'guix (G_ "Looking up package `~a'~%") specification)
> - (match (lookup-inferior-packages (current-guix) specification)
> - ((first . rest) first)
> - (_ (raise (condition
> - (&gwl-package-error
> - (package-spec specification)))))))
> + (let ((name version output
> + (package-specification->name+version+output specification)))
> + (let* ((inferior-package
> + (lookup-inferior-packages (current-guix)
> + name version))
> + (package (match inferior-package
> + ((first . rest) first)
> + (_ (raise (condition
> + (&gwl-package-error
> + (package-spec specification))))))))
You can merge the SRFI-71 “let” with “let*” to a single “let*” and thus
remove one layer of nested parentheses.
> + (set-object-property! package #:gwl/package-output output)
The Guile manual has this to say about “set-object-property!”:
Guile also implements a more traditional Lispy interface to
properties, in which each object has an list of key-value pairs
associated with it. Properties in that list are keyed by symbols. This
is a legacy interface; you should use weak hash tables or object
properties instead.
The preferred way to do this is to define a property, and then use
“set!” and the property getter on the object:
--8<---------------cut here---------------start------------->8---
(define package-output (make-object-property))
(define* (lookup-package …)
…
(set! (package-output package) output) ;store the output as a property
…)
…
(package-output package) ; retrieve the output
--8<---------------cut here---------------end--------------->8---
--
Ricardo
next prev parent reply other threads:[~2022-05-23 21:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 17:22 Packages specification does not work Olivier Dion via
2022-04-21 18:25 ` Olivier Dion via
2022-04-21 19:51 ` [PATCH v1 1/2] packages: Support for full Guix specification Olivier Dion
2022-04-21 19:51 ` [PATCH v1 2/2] pre-inst-env.in: Export GUIX_EXTENSIONS_PATH Olivier Dion
2022-04-29 11:42 ` Ricardo Wurmus
2022-04-21 20:10 ` [PATCH v1 1/2] packages: Support for full Guix specification Olivier Dion via
2022-04-22 18:43 ` [PATCH v2 0/2] Support full package specifications Olivier Dion
2022-04-22 18:43 ` [PATCH v2 1/2] packages: Support for full Guix specification Olivier Dion
2022-04-26 18:11 ` Ricardo Wurmus
2022-04-26 18:59 ` Olivier Dion via
2022-04-26 20:30 ` Ricardo Wurmus
2022-04-26 21:52 ` Olivier Dion via
2022-04-22 18:43 ` [PATCH v2 2/2] pre-inst-env.in: Export GUIX_EXTENSIONS_PATH Olivier Dion
2022-04-29 9:00 ` zimoun
2022-04-29 18:02 ` [PATCH v3 0/1] Support full package specifications Olivier Dion
2022-04-29 18:02 ` [PATCH v3 1/1] packages: Support for full Guix specification Olivier Dion
2022-05-22 6:43 ` Ricardo Wurmus
2022-05-22 12:33 ` Olivier Dion via
2022-05-17 20:40 ` [PATCH v3 0/1] Support full package specifications Olivier Dion via
2022-05-22 12:38 ` [PATCH v4] packages: Support for full Guix specification Olivier Dion
2022-05-23 21:02 ` Ricardo Wurmus [this message]
2022-05-23 21:45 ` [PATCH v5] " Olivier Dion
2022-06-01 13:07 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.guixwl.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee0khs9s.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=gwl-devel@gnu.org \
--cc=olivier.dion@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).