unofficial mirror of gwl-devel@gnu.org
 help / color / mirror / Atom feed
* Support for guile-config 0.5
@ 2022-05-25  3:31 Taiju HIGASHI
  2022-06-01 13:01 ` Ricardo Wurmus
  2022-07-06  8:36 ` Ricardo Wurmus
  0 siblings, 2 replies; 9+ messages in thread
From: Taiju HIGASHI @ 2022-05-25  3:31 UTC (permalink / raw)
  To: gwl-devel

[-- Attachment #1: Type: text/plain, Size: 862 bytes --]

Hi,

I am currently working on the following issue.
https://issues.guix.gnu.org/55612

I have understood that I need to modify gwl to get guile-config 0.5.0
into Guix. However, I know almost nothing about gwl. Is it possible to
get some advice?

It seems that the following commits have incompatible specification
changes.
https://gitlab.com/a-sassmannshausen/guile-config/-/commit/8a107639e8b0f1037518a36fab56dde051b028d8
https://gitlab.com/a-sassmannshausen/guile-config/-/commit/3bf3adde491df551a357a3ac05d137652e825fbe

The `optional` in the configuration specification has been removed and
`argument` and `switch` are now interpreted as mandatory when `default`
is `empty`.

I have created the attached patch based on this fact. The gwl build now
passes.  Is there any other work that needs to be done? I am unsure as I
do not know much about gwl.

Thanks,

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-config-Support-for-new-optional-mandatory-semantics.patch --]
[-- Type: text/x-patch, Size: 1557 bytes --]

From 8caf849c1ed20ba0f80d766acc1854ef53a48d6f Mon Sep 17 00:00:00 2001
From: Taiju HIGASHI <higashi@taiju.info>
Date: Wed, 25 May 2022 00:05:46 +0900
Subject: [PATCH] config: Support for new optional/mandatory semantics.

Because there has been a specification change in the way option
arguments and mandatory switches are specified since guile-config 0.5.
---
 gwl/config.scm.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gwl/config.scm.in b/gwl/config.scm.in
index 9ab58e5..f789998 100644
--- a/gwl/config.scm.in
+++ b/gwl/config.scm.in
@@ -65,7 +65,6 @@ workflow.")
        (list
         (argument
          (name 'file)
-         (optional? #false)
          (test file-exists?)
          (handler identity)
          (example "/path/to/my-workflow.w"))))
@@ -95,12 +94,14 @@ workflow.")
          (character #\i)
          (synopsis "Specify workflow input NAME, optionally mapped to FILE")
          (example "NAME[=FILE]")
+         (default "")
          (test string?))
         (switch
          (name 'output)
          (character #\o)
          (synopsis "Set LOCATION as output for a workflow")
-         (example "LOCATION"))
+         (example "LOCATION")
+         (default ""))
         (switch
          (name 'engine)
          (character #\e)
@@ -147,7 +148,6 @@ format) of the specified workflow.")
        (list
         (argument
          (name 'file)
-         (optional? #false)
          (test file-exists?)
          (handler identity)
          (example "/path/to/my-workflow.w")))))
-- 
2.36.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2022-07-06 10:06 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-25  3:31 Support for guile-config 0.5 Taiju HIGASHI
2022-06-01 13:01 ` Ricardo Wurmus
2022-06-01 14:28   ` Taiju HIGASHI
2022-06-01 20:29     ` Ricardo Wurmus
2022-06-02  0:52       ` Taiju HIGASHI
2022-06-06 11:23         ` Ricardo Wurmus
2022-06-06 15:25           ` Taiju HIGASHI
2022-07-06  8:36 ` Ricardo Wurmus
2022-07-06  9:54   ` Taiju HIGASHI

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).