unofficial mirror of gwl-devel@gnu.org
 help / color / mirror / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Kyle Meyer <kyle@kyleam.com>
Cc: gwl-devel@gnu.org
Subject: Re: [PATCH] workflow: Consider unspecified free inputs when checking cache.
Date: Mon, 24 Jun 2019 15:54:02 +0200	[thread overview]
Message-ID: <874l4ft7gl.fsf@elephly.net> (raw)
In-Reply-To: <20190613034821.1705513-1-kyle@kyleam.com>


Hi Kyle,

> When deciding whether a process is cached, we take into account the
> modification time and size of free inputs, but only those that are
> explicitly specified on the command line.  As a result, the same
> updated input file that would invalidate the cache when given
> explicitly to --input does _not_ invalidate the cache when not
> specified but instead picked from the current working directory.
>
> Correct this discrepancy by including unspecified free inputs in the
> cache prefix calculation.

Thank you for this patch and my apologies for the delay in reviewing the
change!  It took me a little too long to understand the problem and then
even longer to decide whether we should include this workaround or if
there was an alternative that could improve the handling of unspecified
inputs all together.

I ended up splitting it up into two commits: one that names the values,
the other to pass on the unspecified inputs to
make-process->cache-prefix.  I’m not sure if we should keep picking
inputs from the environment silently and by default, but your patch is
anyway more correct than what we had before.

Thanks again!

--
Ricardo

  reply	other threads:[~2019-06-24 13:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-13  3:48 [PATCH] workflow: Consider unspecified free inputs when checking cache Kyle Meyer
2019-06-24 13:54 ` Ricardo Wurmus [this message]
2019-06-25  4:30   ` Kyle Meyer
2019-06-25 17:33     ` zimoun
2019-06-25 18:33       ` Ricardo Wurmus
2019-06-26  1:31       ` Kyle Meyer
2019-06-26  7:05         ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.guixwl.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874l4ft7gl.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=gwl-devel@gnu.org \
    --cc=kyle@kyleam.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).