From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id kF9MMgN2m2IdXwEAbAwnHQ (envelope-from ) for ; Sat, 04 Jun 2022 17:10:59 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id AH48MQN2m2InGwEAG6o9tA (envelope-from ) for ; Sat, 04 Jun 2022 17:10:59 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 72609194F2 for ; Sat, 4 Jun 2022 17:10:59 +0200 (CEST) Received: from localhost ([::1]:46824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nxVQX-0003PY-OQ for larch@yhetil.org; Sat, 04 Jun 2022 11:10:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nxVQT-0003PO-7w for gwl-devel@gnu.org; Sat, 04 Jun 2022 11:10:53 -0400 Received: from smtp.polymtl.ca ([132.207.4.11]:35772) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nxVQQ-0001j0-4l for gwl-devel@gnu.org; Sat, 04 Jun 2022 11:10:51 -0400 Received: from localhost (mtl.savoirfairelinux.net [208.88.110.46]) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 254FAgvG014017; Sat, 4 Jun 2022 11:10:47 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 254FAgvG014017 To: Ricardo Wurmus Cc: gwl-devel@gnu.org Subject: Re: [PATCH] gwl/ui: Check for log-events configuration In-Reply-To: <875ylg5v60.fsf@elephly.net> References: <20220603183203.11092-1-olivier.dion@polymtl.ca> <875ylg5v60.fsf@elephly.net> Date: Sat, 04 Jun 2022 11:10:42 -0400 Message-ID: <874k10xy4t.fsf@laura> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Poly-FromMTA: (mtl.savoirfairelinux.net [208.88.110.46]) at Sat, 4 Jun 2022 15:10:42 +0000 Received-SPF: pass client-ip=132.207.4.11; envelope-from=olivier.dion@polymtl.ca; helo=smtp.polymtl.ca X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: gwl-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gwl-devel-bounces+larch=yhetil.org@gnu.org Sender: "gwl-devel" Reply-to: Olivier Dion From: Olivier Dion via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654355459; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=0BwAQF3P4jgeMPqeJjVvfFzbyMj7KwpW7kOIt/VxeS0=; b=ZSKipWjVc558Fwhcr0Q1YNMiGpBWEQRafN92BTKSJ81HUTwtEp8HnRoBJ1n30YISaas4Yf vvhdwjkbT5w1d2oxYZsAwcgILNbVK6xw9vqOGFuJtlfeozVJRiXeUpeJs/ibLNvYp8abKF HS7NyKQWaWv20mGg9KANIfA8y2Uo5uS3SGHd8f+GBrrxeetNGPUEuYbswcwlQGsGdotpqf Pgj6NwTMMq2tdbgkDtiYxxV9f5mKkUVVvvSKzIfSKM10GR4zi8Ey9f5YXlfoJb+k0cxZrj dALyp7jn4uftilXMqe0xG98B3fJKd3hlqE8PV6vaboLaxVk02/f1hS8s6nMAng== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654355459; a=rsa-sha256; cv=none; b=rK4754BDEpPsEbLpXYD25Hsu/hYfJ87KtnFBM4iWUQqHi2mzeBcFl/JHoIfoX63FQvliAS c9l+5Hp+3M7hpGQx9vTwFJk6usAtD8xP+19aPwFon9VuBemWMvne/NSku3kqO4hWSe6csy O3dGiR5dM/SI2cE32K8moNUufQANzA9yr54Rtlo7iey6mTotJ8V8ilRwjXYzEwunhyqH/Q gSXicz+VjU8pVzNOVqXSyS0b364roLKcZ13LNUt4a83EVBdP7u2hbABNd2Y6kgG+oE1HXj PtidbNXxHw/TFxsx41uOWmIiMwsAtRfTBs/o344sTESbxEZNkqqfmQ3pfJaTKw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "gwl-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="gwl-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.82 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "gwl-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="gwl-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 72609194F2 X-Spam-Score: -3.82 X-Migadu-Scanner: scn0.migadu.com X-TUID: G/+Eb5KT0mep On Sat, 04 Jun 2022, Ricardo Wurmus wrote: > Olivier Dion writes: > >> Some GWL sub-commands such as `graph' do not accept a log event configur= ation. >> This results in returning `#f' from `(%config 'log-events)' > > I don=E2=80=99t understand how this leads to a problem. Do any of the fe= atures > of =E2=80=9Cgraph=E2=80=9D use =E2=80=9Clog-event=E2=80=9D? Yes. `load-workflow' -> `load-workflow*' -> `load*' -> `log-event 'info "Loading workflow file"'. > Generally, I=E2=80=99d prefer to give =E2=80=9Clog-events=E2=80=9D a bett= er default. I can=E2=80=99t > imagine a situation where #F (rather than the empty list) would be > appropriate. The empty list would be a more sane choice I agree. I'll send a v2 with this change. Also, the `print?` predicate could be memoize with `mlambda'? --=20 Olivier Dion oldiob.dev