all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#41297] [PATCH] gnu: openctm: Correct inputs vs native-inputs
@ 2020-05-15 22:57 Ekaitz Zarraga
  2020-05-15 23:35 ` Jonathan Brielmaier
  0 siblings, 1 reply; 6+ messages in thread
From: Ekaitz Zarraga @ 2020-05-15 22:57 UTC (permalink / raw)
  To: 41297

From 417f64adc854e5d717351fec68872ed19a9ac3df Mon Sep 17 00:00:00 2001
From: Ekaitz Zarraga <ekaitz@elenq.tech>
Date: Sat, 16 May 2020 00:49:53 +0200
Subject: [PATCH] gnu: openctm: Correct inputs vs native-inputs

    * gnu/packages/engineering.scm (openctm): Change inputs
---
 gnu/packages/engineering.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index aec692174a..aab414bf0e 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -2557,11 +2557,12 @@ official SDK.")
           (base32 "01wb70m48xh5gwhv60a5brv4sxl0i0rh038w32cgnlxn5x86s9f1"))))
       (build-system gnu-build-system)
       (native-inputs
+       `(("pkg-config" ,pkg-config)))
+      (inputs
        `(("mesa" ,mesa)
          ("glu" ,glu)
          ("glut" ,freeglut)
-         ("gtk" ,gtk+-2)
-         ("pkg-config" ,pkg-config)))
+         ("gtk" ,gtk+-2)))
       (arguments
        `(#:tests? #f                              ;no tests
          #:phases
--
2.26.1






^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#41297] [PATCH] gnu: openctm: Correct inputs vs native-inputs
  2020-05-15 22:57 [bug#41297] [PATCH] gnu: openctm: Correct inputs vs native-inputs Ekaitz Zarraga
@ 2020-05-15 23:35 ` Jonathan Brielmaier
  2020-05-16  9:57   ` Ekaitz Zarraga
  0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Brielmaier @ 2020-05-15 23:35 UTC (permalink / raw)
  To: Ekaitz Zarraga, 41297

On 16.05.20 00:57, Ekaitz Zarraga wrote:
> From 417f64adc854e5d717351fec68872ed19a9ac3df Mon Sep 17 00:00:00 2001
> From: Ekaitz Zarraga <ekaitz@elenq.tech>
> Date: Sat, 16 May 2020 00:49:53 +0200
> Subject: [PATCH] gnu: openctm: Correct inputs vs native-inputs

Please add a dot add the end of sentences.

>     * gnu/packages/engineering.scm (openctm): Change inputs

Maybe rephrase it to: Move pkg-config to native-inputs.

> ---
>  gnu/packages/engineering.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
> index aec692174a..aab414bf0e 100644
> --- a/gnu/packages/engineering.scm
> +++ b/gnu/packages/engineering.scm
> @@ -2557,11 +2557,12 @@ official SDK.")
>            (base32 "01wb70m48xh5gwhv60a5brv4sxl0i0rh038w32cgnlxn5x86s9f1"))))
>        (build-system gnu-build-system)
>        (native-inputs
> +       `(("pkg-config" ,pkg-config)))
> +      (inputs
>         `(("mesa" ,mesa)
>           ("glu" ,glu)
>           ("glut" ,freeglut)
> -         ("gtk" ,gtk+-2)
> -         ("pkg-config" ,pkg-config)))
> +         ("gtk" ,gtk+-2)))
>        (arguments
>         `(#:tests? #f                              ;no tests
>           #:phases
> --

Otherwise it looks good.




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#41297] [PATCH] gnu: openctm: Correct inputs vs native-inputs
  2020-05-15 23:35 ` Jonathan Brielmaier
@ 2020-05-16  9:57   ` Ekaitz Zarraga
  2020-05-16 10:06     ` Jonathan Brielmaier
  0 siblings, 1 reply; 6+ messages in thread
From: Ekaitz Zarraga @ 2020-05-16  9:57 UTC (permalink / raw)
  To: Jonathan Brielmaier; +Cc: 41297@debbugs.gnu.org

Hi,

>
> Maybe rephrase it to: Move pkg-config to native-inputs.
>

In fact, the pkg-config is the only one that it's not moved. The change is moving all of the others to inputs.

I really bad at describing what I did. I don't know how to say it short and accurately :D

Thanks!





^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#41297] [PATCH] gnu: openctm: Correct inputs vs native-inputs
  2020-05-16  9:57   ` Ekaitz Zarraga
@ 2020-05-16 10:06     ` Jonathan Brielmaier
  2020-05-16 10:24       ` Ekaitz Zarraga
  0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Brielmaier @ 2020-05-16 10:06 UTC (permalink / raw)
  To: Ekaitz Zarraga; +Cc: 41297@debbugs.gnu.org

On 16.05.20 11:57, Ekaitz Zarraga wrote:
> Hi,
>
>>
>> Maybe rephrase it to: Move pkg-config to native-inputs.
>>
>
> In fact, the pkg-config is the only one that it's not moved. The change is moving all of the others to inputs.
>
> I really bad at describing what I did. I don't know how to say it short and accurately :D

Ah, so it's the other way round. So move mesa, glu, glut and gtk+-2 to
inputs.




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#41297] [PATCH] gnu: openctm: Correct inputs vs native-inputs
  2020-05-16 10:06     ` Jonathan Brielmaier
@ 2020-05-16 10:24       ` Ekaitz Zarraga
  2020-05-16 17:24         ` Ludovic Courtès
  0 siblings, 1 reply; 6+ messages in thread
From: Ekaitz Zarraga @ 2020-05-16 10:24 UTC (permalink / raw)
  To: Jonathan Brielmaier; +Cc: 41297@debbugs.gnu.org

Hi,

> Ah, so it's the other way round. So move mesa, glu, glut and gtk+-2 to
> inputs.

Short and accurate. Thanks

Here it goes:



From 9e6f5503fd8837bcbb03eed3a05d6105b1752fc3 Mon Sep 17 00:00:00 2001
From: Ekaitz Zarraga <ekaitz@elenq.tech>
Date: Sat, 16 May 2020 12:22:09 +0200
Subject: [PATCH] gnu: openctm: Correct inputs vs native-inputs

    * gnu/packages/engineering.scm (openctm): Move mesa, glu, glut and
    gtk+-2 to inputs
---
 gnu/packages/engineering.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index aec692174a..aab414bf0e 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -2557,11 +2557,12 @@ official SDK.")
           (base32 "01wb70m48xh5gwhv60a5brv4sxl0i0rh038w32cgnlxn5x86s9f1"))))
       (build-system gnu-build-system)
       (native-inputs
+       `(("pkg-config" ,pkg-config)))
+      (inputs
        `(("mesa" ,mesa)
          ("glu" ,glu)
          ("glut" ,freeglut)
-         ("gtk" ,gtk+-2)
-         ("pkg-config" ,pkg-config)))
+         ("gtk" ,gtk+-2)))
       (arguments
        `(#:tests? #f                              ;no tests
          #:phases
--
2.26.1






^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#41297] [PATCH] gnu: openctm: Correct inputs vs native-inputs
  2020-05-16 10:24       ` Ekaitz Zarraga
@ 2020-05-16 17:24         ` Ludovic Courtès
  0 siblings, 0 replies; 6+ messages in thread
From: Ludovic Courtès @ 2020-05-16 17:24 UTC (permalink / raw)
  To: Ekaitz Zarraga; +Cc: 41297@debbugs.gnu.org, Jonathan Brielmaier

Hi,

Ekaitz Zarraga <ekaitz@elenq.tech> skribis:

>>From 9e6f5503fd8837bcbb03eed3a05d6105b1752fc3 Mon Sep 17 00:00:00 2001
> From: Ekaitz Zarraga <ekaitz@elenq.tech>
> Date: Sat, 16 May 2020 12:22:09 +0200
> Subject: [PATCH] gnu: openctm: Correct inputs vs native-inputs
>
>     * gnu/packages/engineering.scm (openctm): Move mesa, glu, glut and
>     gtk+-2 to inputs

Applied, thanks, and sorry for not catching it earlier!

Ludo’.




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-05-16 17:25 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-15 22:57 [bug#41297] [PATCH] gnu: openctm: Correct inputs vs native-inputs Ekaitz Zarraga
2020-05-15 23:35 ` Jonathan Brielmaier
2020-05-16  9:57   ` Ekaitz Zarraga
2020-05-16 10:06     ` Jonathan Brielmaier
2020-05-16 10:24       ` Ekaitz Zarraga
2020-05-16 17:24         ` Ludovic Courtès

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.