From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id oDTqEzMux15rewAA0tVLHw (envelope-from ) for ; Fri, 22 May 2020 01:43:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id MPzIDzMux17MdQAAB5/wlQ (envelope-from ) for ; Fri, 22 May 2020 01:43:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 363FD9400C3 for ; Fri, 22 May 2020 01:43:14 +0000 (UTC) Received: from localhost ([::1]:56674 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbwiN-00082K-Eq for larch@yhetil.org; Thu, 21 May 2020 21:43:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbwiE-000827-Kc for guix-patches@gnu.org; Thu, 21 May 2020 21:43:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46160) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jbwiD-0004IP-RZ for guix-patches@gnu.org; Thu, 21 May 2020 21:43:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jbwiD-0001HK-Pz for guix-patches@gnu.org; Thu, 21 May 2020 21:43:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41181] adds emacs-interleave Resent-From: rdes Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 22 May 2020 01:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41181 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Nicolas Goaziou Cc: 41181@debbugs.gnu.org X-Debbugs-Original-Cc: "41181\\@debbugs.gnu.org" <41181@debbugs.gnu.org>, rdes via Guix-patches via Received: via spool by submit@debbugs.gnu.org id=B.15901117664890 (code B ref -1); Fri, 22 May 2020 01:43:01 +0000 Received: (at submit) by debbugs.gnu.org; 22 May 2020 01:42:46 +0000 Received: from localhost ([127.0.0.1]:57706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbwht-0001Gd-D3 for submit@debbugs.gnu.org; Thu, 21 May 2020 21:42:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:58994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbwhn-0001GL-Nl for submit@debbugs.gnu.org; Thu, 21 May 2020 21:42:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44960) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbwhn-00080L-Gi for guix-patches@gnu.org; Thu, 21 May 2020 21:42:35 -0400 Received: from mail-40137.protonmail.ch ([185.70.40.137]:64441) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbwhl-0004HY-7C for guix-patches@gnu.org; Thu, 21 May 2020 21:42:34 -0400 Date: Fri, 22 May 2020 01:42:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1590111748; bh=L4j+gLg5Yg1MCXI6qJi3r41pgetcbBa6SUA4Dlwim3Q=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=aoayPz/RwD51pLrYHP/6uEzrW0T1Ahtc8HjQ8yLi7FYqNhZhpSze61QksdjTSa1pZ 1sYmRB4g8tkLEvu+gesHqVPeR6e0jxmqvJjiGfJ8ufrqXz5sfHaSKnDfDZRFObo/y8 nynKHRnxEd2YJSIHWEPcejQAvhXfcdCDWNjdvxoc= Message-ID: In-Reply-To: <87367ytbe6.fsf@nicolasgoaziou.fr> References: <875zd3x7z2.fsf@nicolasgoaziou.fr> <-nBsa1KQJSwbENQmZILkCluHwqx_QyjF3PQxKtoNHoOeqeFc1FHy95KjjodciPwOSIH5XOxKIhoHv0Hzb87JVOVy3D1fEb1nD9fDidbeMiU=@protonmail.com> <87367ytbe6.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_13d938635139b6e2946ef47773939454" Received-SPF: pass client-ip=185.70.40.137; envelope-from=rdes@protonmail.com; helo=mail-40137.protonmail.ch X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/21 21:42:29 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -0.0 (/) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: rdes , rdes via Guix-patches From: rdes via Guix-patches via X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=protonmail.com header.s=protonmail header.b=aoayPz/R; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: Y3jE7IckXNv7 This is a multi-part message in MIME format. --b1_13d938635139b6e2946ef47773939454 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello Nicolas, Thanks for the insight. Attached is a patch with the suggestions from the = previous email. -Ryan Sent with ProtonMail Secure Email. =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Sunday, May 17, 2020 7:00 PM, Nicolas Goaziou w= rote: > Hello, > > rdes rdes@protonmail.com writes: > > > Subject: [PATCH] * gnu/packages/emacs-xyz.scm (emacs-interleave):= New > > variable. > > Thank you for the updated patch. Some comments follow. > > > +(define-public emacs-interleave > > > > - (package > > - (name "emacs-interleave") > > - (version "1.4.0") > > - (source > > - (origin > > > > > > - (method git-fetch) > > > > > > - (uri > > > > > > - (git-reference > > > > > > - (url "https://github.com/rudolfochrist/interleave") > > > > > > - (commit (string-append "interleave-" version)))) > > > > > > - (file-name (git-file-name name version)) > > > > > > - (sha256 > > > > > > - (base32 > > > > > > - "0l5b681mrpk12lx5c16m7kc13p29z6zismwg1llsjg7cdmrmsrcb= ")))) > > > > > > Could you move the hash on the line above? > > > - (build-system emacs-build-system) > > - (home-page > > - "https://github.com/rudolfochrist/interleave") > > > > > > Could you move the URI on the line above, too? > > > - (synopsis > > - "A minor mode that presents a document buffer next to an = orgmode buffer") > > > > > > A synopsis does not start with "A". You may want to use "guix lint" to > spot this. > > You might use the summary from the home page: > > (synopsis "Emacs minor mode to interleave notes and text books") > > > - (description > > - "Interleave is a minor mode that presents a document view= er side > > > > > > > > +by side to an orgmode buffer with your notes relevant to the cur= rent > > page.") > > "orgmode buffer" -> "an Org buffer" > > Could you send an updated patch and merge this with the copyright line > you sent? > > Regards, > > ----------------------------------------------------------------------= ----------------------- > > Nicolas Goaziou --b1_13d938635139b6e2946ef47773939454 Content-Type: text/x-patch; name="0001-gnu-packages-emacs-xyz.scm-emacs-interleave-New-vari.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-gnu-packages-emacs-xyz.scm-emacs-interleave-New-vari.patch RnJvbSA4OTk3Y2IyOGJjNjk0YjBhNjE0ZDY5MWRiNTkyY2NmYzFmODViNzkwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSeWFuIERlc2Zvc3NlcyA8cnlhbkBkZXNmby5vcmc+CkRhdGU6 IEZyaSwgMTUgTWF5IDIwMjAgMTY6NTM6MDIgLTA0MDAKU3ViamVjdDogW1BBVENIXSAqIGdudS9w YWNrYWdlcy9lbWFjcy14eXouc2NtIChlbWFjcy1pbnRlcmxlYXZlKTogTmV3CiB2YXJpYWJsZS4K CiogZ251L3BhY2thZ2VzL2VtYWNzLXh5ei5zY206IEFkZCBjb3B5cmlnaHQuCi0tLQogZ251L3Bh Y2thZ2VzL2VtYWNzLXh5ei5zY20gfCAyMyArKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxl IGNoYW5nZWQsIDIzIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvZW1h Y3MteHl6LnNjbSBiL2dudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtCmluZGV4IDQ1Y2NjZWQ5OWUu LjFhMjU1NDc1MDggMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtCisrKyBi L2dudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtCkBAIC03MCw2ICs3MCw3IEBACiA7OzsgQ29weXJp Z2h0IMKpIDIwMjAgQWxiZXJ0byBFbGV1dGVyaW8gRmxvcmVzIEd1ZXJyZXJvIDxiYXJiYW5lZ3Jh K2d1aXhAcG9zdGVvLm14PgogOzs7IENvcHlyaWdodCDCqSAyMDIwIE1hcml1cyBCYWtrZSA8bWJh a2tlQGZhc3RtYWlsLmNvbT4KIDs7OyBDb3B5cmlnaHQgwqkgMjAyMCBwaW5vYWZmZSA8cGlub2Fm ZmVAYWlybWFpbC5jYz4KKzs7OyBDb3B5cmlnaHQgwqkgMjAyMCBSeWFuIERlc2Zvc3NlcyA8cmRl c0Bwcm90b25tYWlsLmNvbT4KIDs7OwogOzs7IFRoaXMgZmlsZSBpcyBwYXJ0IG9mIEdOVSBHdWl4 LgogOzs7CkBAIC02MDUyLDYgKzYwNTMsMjggQEAgdGhlIEh5ZHJhIHZlcnkgc2VhbWxlc3M7IGl0 J3MgbGlrZSBhIG1pbm9yIG1vZGUgdGhhdCBkaXNhYmxlcyBpdHNlbGYKIGF1dG9tYXRpY2FsbHku IikKICAgICAobGljZW5zZSBsaWNlbnNlOmdwbDMrKSkpCiAKKyhkZWZpbmUtcHVibGljIGVtYWNz LWludGVybGVhdmUKKyAgKHBhY2thZ2UKKyAgICAobmFtZSAiZW1hY3MtaW50ZXJsZWF2ZSIpCisg ICAgKHZlcnNpb24gIjEuNC4wIikKKyAgICAoc291cmNlCisgICAgIChvcmlnaW4KKyAgICAgICAo bWV0aG9kIGdpdC1mZXRjaCkKKyAgICAgICAodXJpCisgICAgICAgIChnaXQtcmVmZXJlbmNlCisg ICAgICAgICAodXJsICJodHRwczovL2dpdGh1Yi5jb20vcnVkb2xmb2NocmlzdC9pbnRlcmxlYXZl IikKKyAgICAgICAgIChjb21taXQgKHN0cmluZy1hcHBlbmQgImludGVybGVhdmUtIiB2ZXJzaW9u KSkpKQorICAgICAgIChmaWxlLW5hbWUgKGdpdC1maWxlLW5hbWUgbmFtZSB2ZXJzaW9uKSkKKyAg ICAgICAoc2hhMjU2CisgICAgICAgIChiYXNlMzIgIjBsNWI2ODFtcnBrMTJseDVjMTZtN2tjMTNw Mjl6Nnppc213ZzFsbHNqZzdjZG1ybXNyY2IiKSkpKQorICAgIChidWlsZC1zeXN0ZW0gZW1hY3Mt YnVpbGQtc3lzdGVtKQorICAgIChob21lLXBhZ2UgImh0dHBzOi8vZ2l0aHViLmNvbS9ydWRvbGZv Y2hyaXN0L2ludGVybGVhdmUiKQorICAgIChzeW5vcHNpcyAiRW1hY3MgbWlub3IgbW9kZSB0byBp bnRlcmxlYXZlIG5vdGVzIGFuZCB0ZXh0IGJvb2tzIikKKyAgICAoZGVzY3JpcHRpb24KKyAgICAg IkludGVybGVhdmUgaXMgYSBtaW5vciBtb2RlIHRoYXQgcHJlc2VudHMgYSBkb2N1bWVudCB2aWV3 ZXIgc2lkZQorYnkgc2lkZSB0byBhbiBPcmcgYnVmZmVyIHdpdGggeW91ciBub3RlcyByZWxldmFu dCB0byB0aGUgY3VycmVudCBwYWdlLiIpCisgICAgKGxpY2Vuc2UgbGljZW5zZTpncGwzKykpKQor CiAoZGVmaW5lLXB1YmxpYyBlbWFjcy1pdnkKICAgKHBhY2thZ2UKICAgICAobmFtZSAiZW1hY3Mt aXZ5IikKLS0gCjIuMjYuMgoK --b1_13d938635139b6e2946ef47773939454--