Hello Nicolas,

Thanks for the insight.  Attached is a patch with the suggestions from the previous email.

-Ryan


Sent with ProtonMail Secure Email.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Sunday, May 17, 2020 7:00 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:

&gt; Hello,
&gt;
&gt; rdes rdes@protonmail.com writes:
&gt;
&gt; &gt; Subject: [PATCH] * gnu/packages/emacs-xyz.scm (emacs-interleave): New
&gt; &gt; variable.
&gt;
&gt; Thank you for the updated patch. Some comments follow.
&gt;
&gt; &gt; +(define-public emacs-interleave
&gt; &gt;
&gt; &gt; -   (package
&gt; &gt; -   (name "emacs-interleave")
&gt; &gt; -   (version "1.4.0")
&gt; &gt; -   (source
&gt; &gt; -       (origin
&gt; &gt;
&gt; &gt;
&gt; &gt; -         (method git-fetch)
&gt; &gt;
&gt; &gt;
&gt; &gt; -         (uri
&gt; &gt;
&gt; &gt;
&gt; &gt; -          (git-reference
&gt; &gt;
&gt; &gt;
&gt; &gt; -           (url "https://github.com/rudolfochrist/interleave")
&gt; &gt;
&gt; &gt;
&gt; &gt; -           (commit (string-append "interleave-" version))))
&gt; &gt;
&gt; &gt;
&gt; &gt; -         (file-name (git-file-name name version))
&gt; &gt;
&gt; &gt;
&gt; &gt; -         (sha256
&gt; &gt;
&gt; &gt;
&gt; &gt; -          (base32
&gt; &gt;
&gt; &gt;
&gt; &gt; -           "0l5b681mrpk12lx5c16m7kc13p29z6zismwg1llsjg7cdmrmsrcb"))))
&gt; &gt;
&gt; &gt;
&gt;
&gt; Could you move the hash on the line above?
&gt;
&gt; &gt; -   (build-system emacs-build-system)
&gt; &gt; -   (home-page
&gt; &gt; -       "https://github.com/rudolfochrist/interleave")
&gt; &gt;
&gt; &gt;
&gt;
&gt; Could you move the URI on the line above, too?
&gt;
&gt; &gt; -   (synopsis
&gt; &gt; -       "A minor mode that presents a document buffer next to an orgmode buffer")
&gt; &gt;
&gt; &gt;
&gt;
&gt; A synopsis does not start with "A". You may want to use "guix lint" to
&gt; spot this.
&gt;
&gt; You might use the summary from the home page:
&gt;
&gt; (synopsis "Emacs minor mode to interleave notes and text books")
&gt;
&gt; &gt; -   (description
&gt; &gt; -       "Interleave is a minor mode that presents a document viewer side
&gt; &gt;
&gt; &gt;
&gt; &gt;
&gt; &gt; +by side to an orgmode buffer with your notes relevant to the current
&gt; &gt; page.")
&gt;
&gt; "orgmode buffer" -&gt; "an Org buffer"
&gt;
&gt; Could you send an updated patch and merge this with the copyright line
&gt; you sent?
&gt;
&gt; Regards,
&gt;
&gt; ---------------------------------------------------------------------------------------------
&gt;
&gt; Nicolas Goaziou

</mail@nicolasgoaziou.fr>