all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Charles via Bug reports for GNU Guix <bug-guix@gnu.org>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 50483@debbugs.gnu.org, "Todor Kondić" <tk.code@protonmail.com>,
	efraim@flashner.co.il
Subject: bug#50483: [R] Package r-shiny: Shiny server logic inactive
Date: Thu, 16 Sep 2021 05:57:05 +0000	[thread overview]
Message-ID: <xVeRBlRmeKpSmH41jzmVlwjiaW0XFvfml-IloQno6htbXvCf-kB4O3Ztx1tNAg-P7qN6CG6LJsyxlXhaTZl4xzZyv2nOiNckWQpg2JcuYw4=@protonmail.com> (raw)
In-Reply-To: <86sfy52379.fsf@gmail.com>

Hello, I am responsible to updating the minify build syste to use the updated uglifyjs (now node-uglify-js found in gnu/packages/uglifyjs.scm). When updating I noticed that some R packages had the input uglify-js (the old lisp one). I chose not mess with them at risk of breaking. What I failed to realize is that some R packages (like r-shiny) actually use the minify build-system to do the minifying, thus trying to call the updated uglifyer, while only importing the new one. Other R package like (r-shinytree) do not use the minify build system and instead directly call uglify-js using open-pipe* (these are the ones I didn't want to break).

I would highly suggest against using the old lisp uglifyer since it is outdated by 6 years, and if anyone decides to write some modern javascript, your package will break. Instead simply update the input to ("node-uglify-js" ,node-uglify-js) and don't forget to use module (gnu packages uglifyjs). For the packages like r-shinytree, I would suggest having them use the minify-build system like r-shiny (and also updating to the newer node-uglify-js). I have tested updaing the input, and it works for the ggplot2 example stated earlier in this thread.

Again I'm really sorry for not catching this. It is very late where I am, so if it isn't clear how to update, I can do it tomorrow.




  reply	other threads:[~2021-09-16 13:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-09 12:35 bug#50483: [R] Package r-shiny: Shiny server logic inactive Todor Kondić via Bug reports for GNU Guix
2021-09-15 16:50 ` zimoun
2021-09-16  5:57   ` Charles via Bug reports for GNU Guix [this message]
2021-09-16  6:32     ` zimoun
2021-09-18  5:14       ` Charles via Bug reports for GNU Guix
2021-09-20 19:03         ` zimoun
2021-09-20 19:30           ` Charles via Bug reports for GNU Guix
2021-09-26 12:26             ` Todor Kondić via Bug reports for GNU Guix
2021-09-27 12:50 ` zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='xVeRBlRmeKpSmH41jzmVlwjiaW0XFvfml-IloQno6htbXvCf-kB4O3Ztx1tNAg-P7qN6CG6LJsyxlXhaTZl4xzZyv2nOiNckWQpg2JcuYw4=@protonmail.com' \
    --to=bug-guix@gnu.org \
    --cc=50483@debbugs.gnu.org \
    --cc=charles.b.jackson@protonmail.com \
    --cc=efraim@flashner.co.il \
    --cc=tk.code@protonmail.com \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.