From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id aPUgDtPghWT4GgEASxT56A (envelope-from ) for ; Sun, 11 Jun 2023 16:57:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id WItADtPghWRPegEAauVa8A (envelope-from ) for ; Sun, 11 Jun 2023 16:57:23 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 175573F1B3 for ; Sun, 11 Jun 2023 16:57:23 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q8MV5-0005T6-I9; Sun, 11 Jun 2023 10:57:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8MV4-0005Su-EF for guix-patches@gnu.org; Sun, 11 Jun 2023 10:57:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q8MV4-00075u-6E for guix-patches@gnu.org; Sun, 11 Jun 2023 10:57:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q8MV4-0005tu-0w for guix-patches@gnu.org; Sun, 11 Jun 2023 10:57:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63839] [PATCH] gnu: riscv-pk: don't target riscv64-linux-gnu when current system is riscv64. Resent-From: Z572 <873216071@qq.com> Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 11 Jun 2023 14:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63839 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Josselin Poiret Cc: 63839@debbugs.gnu.org X-Debbugs-Original-Cc: 63839@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.168649539622633 (code B ref -1); Sun, 11 Jun 2023 14:57:01 +0000 Received: (at submit) by debbugs.gnu.org; 11 Jun 2023 14:56:36 +0000 Received: from localhost ([127.0.0.1]:37607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8MUe-0005sy-Aq for submit@debbugs.gnu.org; Sun, 11 Jun 2023 10:56:36 -0400 Received: from lists.gnu.org ([209.51.188.17]:39410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <873216071@qq.com>) id 1q8MUY-0005sl-PS for submit@debbugs.gnu.org; Sun, 11 Jun 2023 10:56:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <873216071@qq.com>) id 1q8MUY-0005Q3-GS for guix-patches@gnu.org; Sun, 11 Jun 2023 10:56:30 -0400 Received: from out203-205-251-36.mail.qq.com ([203.205.251.36]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <873216071@qq.com>) id 1q8MUV-00072q-Cy for guix-patches@gnu.org; Sun, 11 Jun 2023 10:56:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1686495371; bh=cpNiVCnauXMABUa44fSJg0Ul7vgOwJZmlAxkMuruJbI=; h=References:From:To:Cc:Subject:Date:In-reply-to; b=ur0FMZa5roXhPql4pJSqGj8MQ7em8UPe3Y2muHE4w8wyqRbiwL9/oPmqx6Q5hrHST 3CURxSdE4WQH03ybnnmVDgZQj0INAC1pnNtIeYy1rPqpjBbEldpiabfBL4IuVAnYWJ VdpruNz/rgGGIKkgbY0YKEY8eaLDuA3e5thIFaPU= Received: from asus ([111.0.51.197]) by newxmesmtplogicsvrszb9-0.qq.com (NewEsmtp) with SMTP id E092588B; Sun, 11 Jun 2023 22:56:09 +0800 X-QQ-mid: xmsmtpt1686495369t1p1qi99k Message-ID: X-QQ-XMAILINFO: NSObNE1Kae7Z6G1dwQRA4+l+TasCSheAbPl71GPFruHwc48Dn9kDkNPIzAbHNA nYzw4lVDgTp6tLy/wZi8DVi5FaiGb3ReAaVK5UWVSHRqPeE6zrSPStw/KHgiZN/v3ZL0Aj5VrvUH TX4c5sL4ahEXQ748LwQvi3WWzsqgSfumoPknCZXYSIPXNFJsWGeYvrgySLk1i7gHGk5IhA/X5HuA JS6VegzTCN1KTNAiwePP1a3qYGMi9joN5QChhJguTs8YM4DhtmMfJxnNFzRNhVOMAZ7FX7eGKeZb nT0YprF2umnRyKN3UGxUA9zH22VfZjEdv+ga9ubxPlc5JWQIwwolSdU9/iJX3nI+go7gO6FcM+Gv JhmnMhCkelXq4sOdwyaOGdK+7x4AezJqqL64Bu54IevNI5HWYdMMNAky/OP7YbaFG4xYcpDg4Bs0 N1jQyaR3fIKv+bg8GgmsryrTaY50mwGoy34VOh+918LqoneLzdsCxBujNfpFCaassnzL+y2RhzKN SQEZCESOdEOPKi82rMTSOv2N00KY18MqpTuGRHrnjqitzTRJV3IHk+H7Hq1EnSWRNaiJFRaUSrjs we3ICUTkOTlRcToXLYzMk7bCvmdzfjL3r6IhPVy8FPwZc8tNsx/ZLnqsMScGuzEqDahebxYLAHIV X0bQd3HLPW4jRne9fYCN/SffPcwPiw3jMJ3ZG9qQOjDd/q1iDC5/B1IPZ2X/Ubo/6/Jvf0h8JGCm e4Jmq8B97stgHKYmOxBfYXY/nfZ/ol2eha9lHeaRVlVNbj3wBI0adFHtB1D3XWAI4pa8qjvbszlH tHQvgLwNkbA5rfgfv62a6rE6luRh0ijtkQm+zY8eHAed9aBbgiqYRzGFIN8nD2244GxaPl13Y9rb Ta9ApPLehG4s9x+tX+yVtxY9QduT81Hbgo+pC9nRhZsaPCXBgMjspCrcT0v1/ea4QmBs5B3diunO RkvDwq8v8= References: <87ilc08ucn.fsf@jpoiret.xyz> User-agent: mu4e 1.10.2; emacs 30.0.50 Date: Sun, 11 Jun 2023 22:48:20 +0800 In-reply-to: <87ilc08ucn.fsf@jpoiret.xyz> Message-ID: <87o7lmrqt2.fsf@qq.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=203.205.251.36; envelope-from=873216071@qq.com; helo=out203-205-251-36.mail.qq.com X-Spam_score_int: 11 X-Spam_score: 1.1 X-Spam_bar: + X-Spam_report: (1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HELO_DYNAMIC_IPADDR=1.951, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Z572 <873216071@qq.com> X-ACL-Warn: , Z572 via Guix-patches From: Z572 via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1686495443; a=rsa-sha256; cv=none; b=PxqAPMeTZVqAoXErjWjCJ0N41Nw3hNskLCwqkJHk6vCcv5PBfyRNaMkDxN1ubatzoCHAfF hZwkcYq8dLGitO1oJtUheCa8AoihAN3gTbDOsrhPw93bxu2VMHSU1BL+bq59RmPF3LCIfy umwaRpn4YqHGsMgU4vONfdMGFjHQeZMJA9l9xfzVx2gm0W/qsRHUqe23kytOxnpILj3fRw BO56kutkQLyHuKYfF/2idTUdKtGhutyprQGpKlicOI9PDdweyB4BuK/LyKAB1N1Z3aWB/a mk3rGVt/rZy6UcB0ryAL+2KMPQqGZEXcY+Y9RVPNTyVeJjHtF30eMvcE8G04Iw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=qq.com header.s=s201512 header.b=ur0FMZa5; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1686495443; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=cpNiVCnauXMABUa44fSJg0Ul7vgOwJZmlAxkMuruJbI=; b=XEIFd5v7yk4Hc5BK4pGpm86GdRDh5HEaCpjBsGddN3l8vfg+wFFA1/+lNKbtGAjcAtjcnu BG1tsqCljJz9/oHk4amT3SptSE7JK+E3KrSPU70+otsZ8YfDLx3CjgvodTgFeyG6PoKAi5 +0jon58rN3zTYswcU6vE6xIMg8e1x4jJpSsrT+tdSvYBWH1BgEns2/ahV7l+8NG3Zz9BCn u28u1NStel/7No8hTN+xBu6S5SR50wWhySsjJ7SJkA1k+MvFx5IltA5qO2bvOveNH25hRL JoFWdmNQxM6YYQumSSYcuBuOhRNLquJS0ZR5Yghxr99neltAmD1M2hGvyRcfZQ== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=qq.com header.s=s201512 header.b=ur0FMZa5; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -0.02 X-Spam-Score: -0.02 X-Migadu-Queue-Id: 175573F1B3 X-TUID: YawEkKQHDBH+ Josselin Poiret via Guix-patches via writes: > [[PGP Signed Part:Undecided]] > Hi, > > Z572 via Guix-patches via writes: > > >> + ;; riscv-pk can only be built for riscv64. >> + (if (string-prefix? "riscv64" (%current-system)) >> + '() >> + (list >> + #:target "riscv64-linux-gnu")) > > I don't think that's a good idea, in general, consumers of the package > should be the ones specifying for which arch this package builds. For > that purpose, there's the supported-systems field of the package record > type. It's not good in general to hardcode targets in package > definitions. look it's name. because it doesn't make sense to target other targets, like `u-boot-sifive-unmatched' or `opensbi-generic'. > > Best, -- over