From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YBWdC5DkNWJ2AQAAgWs5BA (envelope-from ) for ; Sat, 19 Mar 2022 15:11:28 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id SEQuBJDkNWLJJwAAG6o9tA (envelope-from ) for ; Sat, 19 Mar 2022 15:11:28 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 92E1613C8C for ; Sat, 19 Mar 2022 15:11:27 +0100 (CET) Received: from localhost ([::1]:39480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVZni-0005v2-Nm for larch@yhetil.org; Sat, 19 Mar 2022 10:11:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46000) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVZnL-0005u6-8e for guix-patches@gnu.org; Sat, 19 Mar 2022 10:11:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38077) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVZnK-0000Fs-PH for guix-patches@gnu.org; Sat, 19 Mar 2022 10:11:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nVZnK-0005g5-Ao for guix-patches@gnu.org; Sat, 19 Mar 2022 10:11:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#45692] [PATCH 0/3] Better Support for ZFS on Guix Resent-From: raid5atemyhomework Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 19 Mar 2022 14:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45692 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: Maxime Devos , "45692@debbugs.gnu.org" <45692@debbugs.gnu.org> Received: via spool by 45692-submit@debbugs.gnu.org id=B45692.164769901221759 (code B ref 45692); Sat, 19 Mar 2022 14:11:02 +0000 Received: (at 45692) by debbugs.gnu.org; 19 Mar 2022 14:10:12 +0000 Received: from localhost ([127.0.0.1]:60207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVZmV-0005es-Pk for submit@debbugs.gnu.org; Sat, 19 Mar 2022 10:10:12 -0400 Received: from mail-40138.protonmail.ch ([185.70.40.138]:51158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVZmS-0005eD-UX for 45692@debbugs.gnu.org; Sat, 19 Mar 2022 10:10:09 -0400 Date: Sat, 19 Mar 2022 14:09:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1647699002; bh=327PWoQlzUWVOXkJwOn5QxsKcZkJr2YWAy7dFWy0oM0=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=Bvha7xDvWz3ZOp3BEfGnbUD89J8GXc2NAmXIrZoFd2AfwjXVbjIAP7qPU9Kt6uQvc XGK0+c3aJ/xR7vBNTv51Rjy2cTfqui03RsM0FCo+a/DMJ5rfUyS9D0sSqEzd/g00QN l1ak2deKCWhM7ILXahn9mO5n4xhWZLNa5Rb4Abeli2cf7gzGpP5Chltfdk/c+DWNyB TtIYPEBCfZMgCpOnt05Rjao1WltjD6YIIzl/hpowuUs8/IX/I3pDhR9qbAGkNbkwiu fffXf05zgTUi3R99xzCuiU1ZF9NtNUJEljBSQFs/sgwUSxSneesTiVnyBxE98sCwmV ESEQ988XmwalQ== Message-ID: In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: raid5atemyhomework X-ACL-Warn: , raid5atemyhomework via Guix-patches From: raid5atemyhomework via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647699087; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=327PWoQlzUWVOXkJwOn5QxsKcZkJr2YWAy7dFWy0oM0=; b=EECeSYRtzoqqBXDzEH2Py5aWulD/Qz+924wfcaUfIAenHTvcNNIFoeXxe1+PmZfud4BZZ9 hcE1+YuFAk6VNKeJWq3SFINPEDSYw+Sk1IpvDp70xfRpDHBE83cg3xwwkCHHAyDk6uz9c1 0gGYIiCxlYkjOzsHG5kPddgYQ01JkbS8HzZC0fOTu/Esr0J4QHwKoJaeGGXe2Ul1L/onoD ctpyQpvX6dAhZjwA5RHy7onJUI5thqZp0ClTjjseOMFJeo9lEekk17nfg5tFZcnvUW8Cbu gVHy3dQWUo3rAdY74maE6tar16cWzFyJTzQ4UA4CTkWDrJmTx6sD1HV6snRhlg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647699087; a=rsa-sha256; cv=none; b=VhTJ/iZi0Ilde0A3GObNRJV7EsaEpu/X3aihqQn3U5Z8iBgLtjUHbTQn5IJbgjA9mFOChb iPK+QcwNMn+0stlaSTp1oj0pBc13FupSxq/4JpYmnS20tW0HKyk7FAAqToZC0JP4PO02oM 4UqGx0uzlm/nk7nbe4fei4ONDXvBjs6yde4RceLrF5n+mdNPHlJuvWPjhG1CFdSzLIMAdv dpnSviKsAqVno0Svyd4nPTXf16RaW2Yxo6T1cTsiXcmVHX7GDs7rfetP4FP8A9F81Owc08 IvOg1jVC3Hj+HRdnOVYmcIBDAiOtPSjgUeVF/QMj13WDkAW1hZ+0/hmac8cJ2w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=Bvha7xDv; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.44 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=Bvha7xDv; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 92E1613C8C X-Spam-Score: -4.44 X-Migadu-Scanner: scn0.migadu.com X-TUID: j98i1JoeGdLz Good morning Liliana, > Why is it necessary to define a > file system as a service? Because getting ZFS to work on Linux requires: * That the ZFS module be added to the `initrd` so that Linux-libre can load= it. * That the ZFS module be actually *loaded*, because otherwise the system as= sumes it is loaded on some `udev` trigger. * That the ZFS module is informed of when it should start scanning for ZFS = pools in the system. * That the above step happens before `user-processes` is started. All that additonal complexity is conveniently packaged in the Guix service = system, and you could have learned that if you had just bothered to actuall= y read the patch. + (list ;; Install OpenZFS kernel module into kernel profile. + (service-extension linux-loadable-module-service-type + zfs-loadable-modules) + ;; And load it. + (service-extension kernel-module-loader-service-type + (const '("zfs"))) + ;; Make sure ZFS pools and datasets are mounted at + ;; boot. + (service-extension shepherd-root-service-type + zfs-shepherd-services) + ;; Make sure user-processes don't start until + ;; after ZFS does. + (service-extension user-processes-service-type + zfs-user-processes) + ;; Install automated scrubbing and snapshotting. + (service-extension mcron-service-type + zfs-mcron-jobs) + + ;; Install ZFS management commands in the system + ;; profile. + (service-extension profile-service-type + (compose list make-zfs-package)) + ;; Install ZFS udev rules. + (service-extension udev-service-type + (compose list make-zfs-package)))) > Why do we need to export a seemingly > unrelated variable? If you are referring to the `dependency->shepherd-service-name` variable, i= t is necessary in order to defer starting of ZFS pool scanning to after all= `mapped-device` dependencies have been opened. > Can this be tested? Is this sufficiently tested? Yes, I have run VMs on each version I have ever sent. > Are there any points Maxime that were drowned out by a huge wall of > licensing-related messages being passed back and forth that I will not > attempt to sift through in order to respond to this message? If so, > have those been sufficiently addressed? Other than grammar and wording of documentation / comments, and one point a= bout using Guix-style Scheme instead of a bit of shell (even though there a= re probably more people who can properly review the latter than the former)= , Maxime had no other points. Other reviewers had and those were already addressed. > > Another complicating factor for this bug in particular is that the mumi > web interface and the raw messages are out of sync; I have no idea why > that is the case, but trying to fetch a patch only to get one of your > bump messages is not particularly encouraging. Oh come on stop your shitty excuses. Nobody would look at this unless I sh= owed up at least once a week to pester Guix maintainers. I already tried t= he wait-for-people-and-they-will-come. Squeaky wheel gets the grease. If = you want contributors to be more respectful, then put up definitive respons= ibilities of who to contact for what and what to do if patches are being ig= nored. Otherwise I am just going to talk smack at you, Prikler. NO Thanks raid5atemyhomework