From: Roel Janssen <roel@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org
Subject: Re: Add the git commit id to the generation information
Date: Tue, 30 May 2017 11:21:53 +0200 [thread overview]
Message-ID: <rbud1aq66oe.fsf@gnu.org> (raw)
In-Reply-To: <87k24y4te6.fsf@elephly.net>
Ricardo Wurmus writes:
> Hi Roel,
>
>> I have a feature request.
>>
>> When I run 'guix pull', install a package, run 'guix pull' again (on
>> another day), and install another package, I'd get two generations:
>>
>>> Generation 181 May 22 2017 11:47:37
>>> + haunt 0.2.1 out /gnu/store/x2bkpzrdbaxavl29r2xg0fip1jjici9q-haunt-0.2.1
>>>
>>> Generation 182 May 24 2017 09:52:06 (current)
>>> + guile-commonmark 0.1 out /gnu/store/k8vq65czfb8k4hvvjvsca34scd9xsxik-guile-commonmark-0.1
>>
>> Now, if I'd like to go to the Guix packages source code of generation
>> 181, I can only guess at which actual state of the Guix repository this
>> was, because this timestamp is the timestamp of creating the generation,
>> not the timestamp of the Guix package state. So, I'd like to propose to
>> add the commit id to the generation like so:
>>
>>> Generation 181 May 22 2017 11:47:37 (ae548434337cddf9677a4cd52b9370810b2cc9b6)
>>> + haunt 0.2.1 out /gnu/store/x2bkpzrdbaxavl29r2xg0fip1jjici9q-haunt-0.2.1
>>>
>>> Generation 182 May 24 2017 09:52:06 (current)
>>> + guile-commonmark 0.1 out /gnu/store/k8vq65czfb8k4hvvjvsca34scd9xsxik-guile-commonmark-0.1
>
> What would be the expected behaviour in the presence of
> GUIX_PACKAGE_PATH? I could have had GUIX_PACKAGE_PATH set pointing to a
> module containing a custom variant of haunt.
>
> I do agree that it would be very useful to know more about the state of
> Guix for any given generation. However, that state is more complex than
> a single commit.
Oh, indeed.. Any suggestions?
My other thought on this, is to add a tagging mechanism, that users can
simply add tags to a generation, of which one could be the commit id.
I think that having the upstream git commit ID already improves the
situation. Adding external repositories is not something the upstream
distribution can take care of. Maybe if we would add a different, more
formal way of allowing external repositories, that could be dealt with
more easily. (Is this what 'channels' could do?)
Kind regards,
Roel Janssen
next prev parent reply other threads:[~2017-05-30 9:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 8:00 Add the git commit id to the generation information Roel Janssen
2017-05-30 8:54 ` Ricardo Wurmus
2017-05-30 9:21 ` Roel Janssen [this message]
2017-05-30 15:48 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=rbud1aq66oe.fsf@gnu.org \
--to=roel@gnu.org \
--cc=guix-devel@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.