From: Jean Pierre De Jesus DIAZ via Guix-patches via <guix-patches@gnu.org>
To: "56768@debbugs.gnu.org" <56768@debbugs.gnu.org>
Subject: [bug#56768] [PATCH] gnu: engineering: Add qucs-s.
Date: Sat, 06 Aug 2022 10:15:02 +0000 [thread overview]
Message-ID: <qOtd5kwWRHyxQdBoWCRYoT7P1Igr72bkwKK5hHCkbQmEV6l84tMY7NGE6uP3vsPQjbBxk8TtooIYP6yO2z1Z4mVVCUSRC-kcwV7Cb-BobKg=@jeandudey.tech> (raw)
In-Reply-To: <87ilnlgduf.fsf@gmail.com>
Hello Artyom,
Just a nitpick:
>+ (description
>+ "@code{Qucs-S} provides a fancy graphical user interface for a number of
@code{Qucs-S} -> @acronym{Qucs-S, Quite universal circuit simulator with SPICE}
>Yet at least Qucs-S will always use the right Octave/NGSpice path from
>GNU Guix.
If the substitute of the binaries path is only done on the `else' block then
the settings would be respected.
For example, on:
https://github.com/ra3xdh/qucs_s/blob/master/qucs/main.cpp#L130-L136
> if(settings.contains("NgspiceExecutable")) QucsSettings.NgspiceExecutable = settings.value("NgspiceExecutable").toString();
> else {
> QString ngsp_exe = QCoreApplication::applicationDirPath() +
> QDir::separator() + "ngspice" + executableSuffix;
> if (!QFile::exists(ngsp_exe)) ngsp_exe = QString("ngspice") + executableSuffix;
> QucsSettings.NgspiceExecutable = ngsp_exe;
> }
Can be substituted to:
if(settings.contains("NgspiceExecutable")) QucsSettings.NgspiceExecutable = settings.value("NgspiceExecutable").toString();
else {
QString ngsp_exe = "/gnu/store/<substitute* used here>";
if (!QFile::exists(ngsp_exe)) ngsp_exe = QString("ngspice") + executableSuffix;
QucsSettings.NgspiceExecutable = ngsp_exe;
}
Then if `NgspiceExecutable' is present on the configuration that value will be used, otherwise the default
one provided by GNU Guix. Same applies for the other executable files.
—
Jean-Pierre De Jesus DIAZ
next prev parent reply other threads:[~2022-08-06 10:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 20:02 [bug#56768] [PATCH] gnu: engineering: Add qucs-s Artyom V. Poptsov
2022-07-26 18:07 ` Maxime Devos
2022-07-29 15:26 ` Artyom V. Poptsov
2022-07-29 16:17 ` Maxime Devos
2022-07-30 6:59 ` Artyom V. Poptsov
2022-08-06 11:42 ` Maxime Devos
2022-08-06 10:15 ` Jean Pierre De Jesus DIAZ via Guix-patches via [this message]
2022-09-04 16:00 ` Artyom V. Poptsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='qOtd5kwWRHyxQdBoWCRYoT7P1Igr72bkwKK5hHCkbQmEV6l84tMY7NGE6uP3vsPQjbBxk8TtooIYP6yO2z1Z4mVVCUSRC-kcwV7Cb-BobKg=@jeandudey.tech' \
--to=guix-patches@gnu.org \
--cc=56768@debbugs.gnu.org \
--cc=me@jeandudey.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.