From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id WHMNLGhRRmcUjAAAe85BDQ:P1 (envelope-from ) for ; Tue, 26 Nov 2024 22:53:28 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id WHMNLGhRRmcUjAAAe85BDQ (envelope-from ) for ; Tue, 26 Nov 2024 23:53:28 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=KS0S6UX9; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1732661608; a=rsa-sha256; cv=none; b=oxHwFAR8KTmuAdqvRoO+NRAVArgQclxd1QM1VbvyVKbvIsa8oeD4hBEa43lljJr0ek5cr+ ty68fO43VEs1jYWd6u31IMCxRR20R7k0QuflbcAsO7nPQIkHZkbbZBXfgCuJkXXDY77o+p hZUSnSe6BiOhZCKuO++447s3Kg5l9Jw22QdHt5Ay73Yae1sbvDWCDDURtsTUNnmdNa13mv 4HSiBgzoUCV8fXBSG3NgTQdD43s9lvO69Xs6l8WalJTE/sAjaR2pYAKSSVnpE82L1xXH5y FQEkzZJHkllX4+UKqbCKR8vBswmCeu1gY6E6QBz1wgzb+ETEilAh2G7QKkmkdg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=KS0S6UX9; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1732661608; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=dAs6ZcwTXVGBQ1cR1norUn3f2zfAKewxCg1wto5yCHg=; b=eyi2cwPnTcgTjrTJaDBdk/NORIfNH+GCxQIX1iD88BtEYzWk84wwIBVL3LftyvvuQEKlux LVgJTaOpJNClUuQCJijUGkcsbB+kujgmOuKzuGuDIuerF2/Uxi1T5MIiPUM3FPtPAITDvu JlcO9Gtk6wpjvabTNqIrqz+eHjz/bTy0ck1MaRvzPwvZBnvk8q8NQB6ZZn2YNVfKwP4/Y5 wRw6Gb/dgrDvEgZEmMTxjMIisYBkLRDx669nLs2AIIWPYnFg84kBdLl5nzD6l+4U96mBI4 j1VbC8oKupOVYw1utAQht+vGUIxGjv3OtG+cSovd9QuK/ZaqhxYOopbGPDHT4A== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B959479829 for ; Tue, 26 Nov 2024 23:53:27 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tG4Qe-0005Qx-6g; Tue, 26 Nov 2024 17:53:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tG4QZ-0005Om-A2 for guix-patches@gnu.org; Tue, 26 Nov 2024 17:53:05 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tG4QZ-0005JG-1A for guix-patches@gnu.org; Tue, 26 Nov 2024 17:53:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:MIME-Version:References:From:Date:To:Subject; bh=dAs6ZcwTXVGBQ1cR1norUn3f2zfAKewxCg1wto5yCHg=; b=KS0S6UX9DFO9TNKd6Tqss/Lq73Ln4B+5+2I8iW+DyXfADqowO6CiILH2WSVSp7VhZ5EZFFQ85gR5/YNSLKlC2aW8GcJWX39HUXXAxOADRyxqSomwHrLlmW1QAOKXkjvLUbtUa6dmnqRFyAZm7c7qxbj/6w/wc8WZ1k3FqDtqXYbB2ErBBeEIFVaQeWfCSG0SXppNZWx417T8Y6Zi36Jf3sCaCG6CITDU+BXYl3b/Z++sjIqRn9jTqPFysujz3gwOYkBEPExU8vv+/Zwy9LiU8gJ9PIoXLfm2LwXqGDt3ehAQ0R5iNKN2jaSoHkdt3igdZZdLWBEnAOGV5kaK4U2DgA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tG4QX-00061h-Rd for guix-patches@gnu.org; Tue, 26 Nov 2024 17:53:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74344] Review Resent-From: Gabriel Wicki Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 26 Nov 2024 22:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74344 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sughosha Cc: 74344@debbugs.gnu.org Received: via spool by 74344-submit@debbugs.gnu.org id=B74344.173266156823137 (code B ref 74344); Tue, 26 Nov 2024 22:53:01 +0000 Received: (at 74344) by debbugs.gnu.org; 26 Nov 2024 22:52:48 +0000 Received: from localhost ([127.0.0.1]:55340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tG4QK-000616-0B for submit@debbugs.gnu.org; Tue, 26 Nov 2024 17:52:48 -0500 Received: from cotopaxi.ee.ethz.ch ([129.132.148.196]:36543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tG4QI-00060q-0g for 74344@debbugs.gnu.org; Tue, 26 Nov 2024 17:52:46 -0500 Received: from localhost (antispam.ee.ethz.ch [129.132.2.16]) by cotopaxi.ee.ethz.ch (Postfix) with ESMTP id 019D6207E1; Tue, 26 Nov 2024 23:52:39 +0100 (CET) X-Virus-Scanned: by amavisd at antispam.ee.ethz.ch Received: from cotopaxi.ee.ethz.ch ([129.132.148.196]) by localhost (antispam.ee.ethz.ch [129.132.2.16]) (amavisd-new, port 10028) with ESMTP id YWmZ9gvOulIh; Tue, 26 Nov 2024 23:52:38 +0100 (CET) Received: from blackbox (212-51-128-25.fiber7.init7.net [212.51.128.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gabriel) by cotopaxi.ee.ethz.ch (Postfix) with ESMTPSA; Tue, 26 Nov 2024 23:52:38 +0100 (CET) Date: Tue, 26 Nov 2024 23:52:35 +0100 From: Gabriel Wicki Message-ID: References: <009f0224022cd4677679737eb01a26142e658152.1731512782.git.sughosha@disroot.org> <8682c543b89052ca0f0f76b5159e1da9f43f1ede.1731512783.git.sughosha@disroot.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8682c543b89052ca0f0f76b5159e1da9f43f1ede.1731512783.git.sughosha@disroot.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: B959479829 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -8.91 X-Spam-Score: -8.91 X-TUID: 68h4PNEUGzz7 hello there! thanks for the submission! general remarks: try not to duplicate the synopsis in the description, otherwise everything looks fine! some questions/remarks: - why disable building examples and demo in qt-advanced-docking-system? - i am not sure the (chdir "../source") is necessary in qtpromise. can't you (substitute* "../source/include/QtPromise" ...) directly? - wouldn't it be nicer to call the variable (and the package) widget-animation-framework instead of widgetanimationframework? or qt-widget-animation-framework? - what does the (snippet ...) do in widgetanimationframework? you could comment why this is necessary have a nice week gabber