[bug#67453] [PATCH] home: services: unclutter: Convert to non-one-shot service

[bug#67453] [PATCH] home: services: unclutter: Convert to non-one-shot service

[Saku Laesvuori via Guix-patches via]

* gnu/home/services/desktop.scm (home-unclutter-shepherd-service)
[one-shot?]: Remove field.
[stop]: Add kill action.

Change-Id: I33551607b05dbac30da94f81fd605ff9624ebe24
---
 gnu/home/services/desktop.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/home/services/desktop.scm b/gnu/home/services/desktop.scm
index 91465bf168..6bb117ea8c 100644
--- a/gnu/home/services/desktop.scm
+++ b/gnu/home/services/desktop.scm
@@ -347,7 +347,6 @@ (define (home-unclutter-shepherd-service config)
    (shepherd-service
     (provision '(unclutter))
     (requirement '())
-    (one-shot? #t)
     (start #~(make-forkexec-constructor
               (list
                #$(file-append
@@ -360,7 +359,8 @@ (define (home-unclutter-shepherd-service config)
                           (or (getenv "XDG_STATE_HOME")
                               (format #f "~a/.local/state"
                                       (getenv "HOME")))
-                          "/log/unclutter.log"))))))
+                          "/log/unclutter.log")))
+    (stop #~(make-kill-destructor)))))
 
 (define home-unclutter-service-type
   (service-type

base-commit: 9f67681db15d22f7ede5488315d52b78e357343e
-- 
2.41.0

[bug#67453] [PATCH] home: services: unclutter: Convert to non-one-shot service

[Saku Laesvuori via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

On Sun, Nov 26, 2023 at 11:00:15AM +0200, Saku Laesvuori wrote:
> * gnu/home/services/desktop.scm (home-unclutter-shepherd-service)
> [one-shot?]: Remove field.
> [stop]: Add kill action.

A reminder about this trivial change. The unclutter service spawns a
process that hides the cursor when it is inactive. The process runs for
the entire session and killing it causes the cursor to stay visible even
when inactive, so it seems to me that it should be provided by a normal
service that can be started/stopped.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#67453] [PATCH] home: services: unclutter: Convert to non-one-shot service

[Saku Laesvuori via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 615 bytes --]

On Mon, Jan 15, 2024 at 05:50:12PM +0200, Saku Laesvuori wrote:
> On Sun, Nov 26, 2023 at 11:00:15AM +0200, Saku Laesvuori wrote:
> > * gnu/home/services/desktop.scm (home-unclutter-shepherd-service)
> > [one-shot?]: Remove field.
> > [stop]: Add kill action.
> 
> A reminder about this trivial change. The unclutter service spawns a
> process that hides the cursor when it is inactive. The process runs for
> the entire session and killing it causes the cursor to stay visible even
> when inactive, so it seems to me that it should be provided by a normal
> service that can be started/stopped.

Ping

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]