From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Hinsen Subject: Re: Looking for help with packaging a Common Lisp library Date: Sun, 26 Jan 2020 11:54:43 +0100 Message-ID: References: <87k15fa60q.fsf@ambrevar.xyz> <87muab8qf7.fsf@yamatai> <878slv9ual.fsf@ambrevar.xyz> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:40086) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivfZ2-00042a-8T for guix-devel@gnu.org; Sun, 26 Jan 2020 05:54:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ivfZ1-00035D-0A for guix-devel@gnu.org; Sun, 26 Jan 2020 05:54:48 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:37525) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ivfZ0-00031n-Ly for guix-devel@gnu.org; Sun, 26 Jan 2020 05:54:46 -0500 In-Reply-To: <878slv9ual.fsf@ambrevar.xyz> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: Pierre Neidhardt , Guillaume Le Vaillant , guix-devel@gnu.org Pierre Neidhardt writes: > The Guix package recreates the .asd file (without the > defsystem-depends-on), which is why it worked in Quicklisp but not in > Guix. OK, that makes sense. > We could merge Guillaume's patch, but first I'd like to make sure that > this is not an upstream bug. Isn't cffi-grovel supposed to be added to > the :depends-on list instead? I am certainly not the right person to answer that question. But here's what the ASDF manual says: The :defsystem-depends-on option to defsystem allows the programmer to specify another ASDF-defined system or set of systems that must be loaded before the system definition is processed. Typically this is used to load an ASDF extension that is used in the system definition. This looks like what the cffi-grovel manual suggests, with an example: https://common-lisp.net/project/cffi/manual/html_node/Groveller-ASDF-Integration.html#Groveller-ASDF-Integration In hdf5-cffi.asd, some components are labelled :cffi-grovel-file, which looks like an ASDF extension provided by cffi-grovel. If that is true, then the :defsystem-depends-on is necessary. A quick test supports that hypothesis: if you remove the line, the system fails to load. Cheers, Konrad.