From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id aGmvAXbg0F68agAA0tVLHw (envelope-from ) for ; Fri, 29 May 2020 10:14:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id WKb1OHXg0F4UdwAAbx9fmQ (envelope-from ) for ; Fri, 29 May 2020 10:14:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BE425940538 for ; Fri, 29 May 2020 10:14:12 +0000 (UTC) Received: from localhost ([::1]:39236 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jec1j-0004eJ-OU for larch@yhetil.org; Fri, 29 May 2020 06:14:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54588) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jebzf-0001YV-TR for guix-patches@gnu.org; Fri, 29 May 2020 06:12:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42318) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jebzf-0002qP-He for guix-patches@gnu.org; Fri, 29 May 2020 06:12:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jebze-0004Jq-DL for guix-patches@gnu.org; Fri, 29 May 2020 06:12:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41253] [PATCH v3] guix repl: Add script execution. Resent-From: Konrad Hinsen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 29 May 2020 10:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41253 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 41253@debbugs.gnu.org, zimoun Received: via spool by 41253-submit@debbugs.gnu.org id=B41253.159074710616581 (code B ref 41253); Fri, 29 May 2020 10:12:02 +0000 Received: (at 41253) by debbugs.gnu.org; 29 May 2020 10:11:46 +0000 Received: from localhost ([127.0.0.1]:53864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jebzF-0004JC-Vd for submit@debbugs.gnu.org; Fri, 29 May 2020 06:11:46 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:51803) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jebzD-0004Iu-EO for 41253@debbugs.gnu.org; Fri, 29 May 2020 06:11:37 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 36DB4A32; Fri, 29 May 2020 06:11:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 29 May 2020 06:11:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.net; h= from:to:to:subject:in-reply-to:references:date:message-id :mime-version:content-type:content-transfer-encoding; s=fm3; bh= rPE3iOk5hWESar1g3xcrYBu9PzNT9Lt8/S9ap7vy3uw=; b=Kbe9HpTs2erTWnV+ d9lJanbQJmkfqFikhsdVKH/4ob7ZlVIO4v6fSexNMF+A/Qhc2Ju2fW9/xf9eftny JgCIuuNqqtSfMp4/g97NweGERoW2dWWYDQs8YPU8SomObTkIWqhmu/NvzIUNZfE6 sCZdPvnGAWjqvExdEn4V+wk4aXdcxvs+DRDOIpkwKuka9J0Hq/MqNb+muM49Pfes +yahM7Rz5S2rmg7m60lIqi421itQ6xu1ZmTUb+kRtyix8+/B9lsccoriRKQvpInG oZMrdXK1v3GpsqbFwZPAO2G4ArKUZJmbX6iL0WkqtuEhIjZVld0jie0g47cejlJY QPz6Cw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=rPE3iOk5hWESar1g3xcrYBu9PzNT9Lt8/S9ap7vy3 uw=; b=CkN7hpXvbb82jWNW/EVB7CxZeIkgMiYfhoqGW6nDiowEeBeOdguz7AFJ9 eqeaGcdSOZPnRUyOuooCQ5zBXVDa5Sgwa+dONW1gdxhmA3sa/f7OApnSIpU3qZLa RDAhfpr22j9WL3+LxY+qkgIucSPC7c5cdegQHmb8Zg2FPBKDkFhTC9WqoSybAkel 6T53l8wBkR4zUpdG1lJBIMJgYWzD9GoOIBEWd6gUd7McMN0WrzwpDfabsDmDjrMo pjKqSLtCIuPLszVckb7z7NeZS2bd/5zhlrdzu8O3MvdRDDMPuQx0UiLenc7SgPLg 9mBzKdx7btwaKab3TEZapk6R+vGSA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddvkedgudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucgotffhvedqqdfjughrqdfuuhhsphgvtghtqdhloh ifucdlhedmnecujfgurhephffvvffujghffffkgggtgfesthhqredttddtjeenucfhrhho mhepmfhonhhrrgguucfjihhnshgvnhcuoehkohhnrhgrugdrhhhinhhsvghnsehfrghsth hmrghilhdrnhgvtheqnecuggftrfgrthhtvghrnhephfehuddvfeetgeeuffegjeeileeg jedvhfejjeejleevvdfhjeevvddttddvudffnecuffhomhgrihhnpehgnhhurdhorhhgne cukfhppeejjedrvddtgedrvdeghedrjeegnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomhepkhhonhhrrggurdhhihhnshgvnhesfhgrshhtmhgrih hlrdhnvght X-ME-Proxy: Received: from KHs-MacBook (74.245.204.77.rev.sfr.net [77.204.245.74]) by mail.messagingengine.com (Postfix) with ESMTPA id CD4B43061CB6; Fri, 29 May 2020 06:11:27 -0400 (EDT) From: Konrad Hinsen In-Reply-To: <20200514162537.29071-1-zimon.toutoune@gmail.com> References: <20200514162537.29071-1-zimon.toutoune@gmail.com> Date: Fri, 29 May 2020 12:11:26 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=fastmail.net header.s=fm3 header.b=Kbe9HpTs; dkim=fail (body hash did not verify) header.d=messagingengine.com header.s=fm2 header.b=CkN7hpXv; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fastmail.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 1.59 X-TUID: asKrTAR5/Kme * guix/scripts/repl.scm: Add filename options for script execution. * doc/guix.texi (Invoking guix repl): Document it. * tests/guix-repl.sh: Test it. --- Makefile.am | 1 + doc/guix.texi | 45 ++++++++++++++++++----- guix/scripts/repl.scm | 84 ++++++++++++++++++++++++++----------------- tests/guix-repl.sh | 78 ++++++++++++++++++++++++++++++++++++++++ 4 files changed, 167 insertions(+), 41 deletions(-) create mode 100644 tests/guix-repl.sh diff --git a/Makefile.am b/Makefile.am index 5b64386b53..859b6a4bc2 100644 --- a/Makefile.am +++ b/Makefile.am @@ -473,6 +473,7 @@ SH_TESTS =3D \ tests/guix-environment-container.sh \ tests/guix-graph.sh \ tests/guix-describe.sh \ + tests/guix-repl.sh \ tests/guix-lint.sh =20 TESTS =3D $(SCM_TESTS) $(SH_TESTS) diff --git a/doc/guix.texi b/doc/guix.texi index 5b9942d420..aeb88a95b6 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -239,7 +239,7 @@ Programming Interface * Derivations:: Low-level interface to package derivations. * The Store Monad:: Purely functional interface to the store. * G-Expressions:: Manipulating build expressions. -* Invoking guix repl:: Fiddling with Guix interactively. +* Invoking guix repl:: Programming Guix in Guile =20 Defining Packages =20 @@ -5466,7 +5466,7 @@ package definitions. * Derivations:: Low-level interface to package derivations. * The Store Monad:: Purely functional interface to the store. * G-Expressions:: Manipulating build expressions. -* Invoking guix repl:: Fiddling with Guix interactively. +* Invoking guix repl:: Programming Guix in Guile @end menu =20 @node Package Modules @@ -8240,12 +8240,38 @@ has an associated gexp compiler, such as a @code{}. @node Invoking guix repl @section Invoking @command{guix repl} =20 -@cindex REPL, read-eval-print loop -The @command{guix repl} command spawns a Guile @dfn{read-eval-print loop} -(REPL) for interactive programming (@pxref{Using Guile Interactively,,, gu= ile, -GNU Guile Reference Manual}). Compared to just launching the @command{gui= le} +@cindex REPL, read-eval-print loop, script +The @command{guix repl} command makes it easier to program Guix in Guile +by launching a Guile @dfn{read-eval-print loop} (REPL) for interactive +programming (@pxref{Using Guile Interactively,,, guile, +GNU Guile Reference Manual}), or by running Guile scripts +(@pxref{Running Guile Scripts,,, guile, +GNU Guile Reference Manual}). +Compared to just launching the @command{guile} command, @command{guix repl} guarantees that all the Guix modules and all = its -dependencies are available in the search path. You can use it this way: +dependencies are available in the search path. + +The general syntax is: + +@example +guix repl @var{options} @var{files} +@end example + +When at least one @var{files} argument is provided, @var{files} are +executed as Guile scripts in the given order: + +@example +$ guix repl my-script.scm +@end example + +To pass arguments to the script, use @code{--} to prevent them from +being interpreted as arguments to @command{guix repl} itself: + +@example +$ guix repl -- my-script.scm --input=3Dfoo.txt +@end example + +Without any filename argument, a Guile REPL is started: =20 @example $ guix repl @@ -8294,11 +8320,12 @@ Add @var{directory} to the front of the package mod= ule search path (@pxref{Package Modules}). =20 This allows users to define their own packages and make them visible to -the command-line tool. +the script or REPL. =20 @item -q Inhibit loading of the @file{~/.guile} file. By default, that -configuration file is loaded when spawning a @code{guile} REPL. +configuration file is loaded when executing scripts or spawning +a @code{guile} REPL. @end table =20 @c ********************************************************************* diff --git a/guix/scripts/repl.scm b/guix/scripts/repl.scm index ff1f208894..f8d0483ad5 100644 --- a/guix/scripts/repl.scm +++ b/guix/scripts/repl.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright =C2=A9 2018, 2019, 2020 Ludovic Court=C3=A8s ;;; Copyright =C2=A9 2020 Simon Tournier +;;; Copyright =C2=A9 2020 Konrad Hinsen ;;; ;;; This file is part of GNU Guix. ;;; @@ -32,10 +33,12 @@ =20 ;;; Commentary: ;;; -;;; This command provides a Guile REPL +;;; This command provides a Guile script runner and REPL in an environment +;;; that contains all the modules comprising Guix. =20 (define %default-options - `((type . guile))) + `((script-args . ()) + (type . guile))) =20 (define %options (list (option '(#\h "help") #f #f @@ -63,8 +66,9 @@ =20 =20 (define (show-help) - (display (G_ "Usage: guix repl [OPTIONS...] -Start a Guile REPL in the Guix execution environment.\n")) + (display (G_ "Usage: guix repl [OPTIONS...] [-- FILE ARGS...] +In the Guix execution environment, run FILE as a Guile script with +command-line arguments ARGS. If no FILE is given, start a Guile REPL,\n")) (display (G_ " -t, --type=3DTYPE start a REPL of the given TYPE")) (display (G_ " @@ -135,42 +139,58 @@ call THUNK." (define (guix-repl . args) (define opts - ;; Return the list of package names. (args-fold* args %options (lambda (opt name arg result) (leave (G_ "~A: unrecognized option~%") name)) (lambda (arg result) - (leave (G_ "~A: extraneous argument~%") arg)) + (alist-cons 'script-args + (cons arg (cdr (assq 'script-args result))) + result)) %default-options)) - +=20=20 (define user-config (and=3D> (getenv "HOME") (lambda (home) (string-append home "/.guile")))) =20 + (define (set-user-module) + (set-current-module user-module) + (when (and (not (assoc-ref opts 'ignore-dot-guile?)) + user-config + (file-exists? user-config)) + (load user-config))) + (with-error-handling - (let ((type (assoc-ref opts 'type))) - (call-with-connection (assoc-ref opts 'listen) - (lambda () - (case type - ((guile) - (save-module-excursion - (lambda () - (set-current-module user-module) - (when (and (not (assoc-ref opts 'ignore-dot-guile?)) - user-config - (file-exists? user-config)) - (load user-config)) - - ;; Do not exit repl on SIGINT. - ((@@ (ice-9 top-repl) call-with-sigint) - (lambda () - (start-repl)))))) - ((machine) - (machine-repl)) - (else - (leave (G_ "~a: unknown type of REPL~%") type)))))))) - -;; Local Variables: -;; eval: (put 'call-with-connection 'scheme-indent-function 1) -;; End: + (let ((script-args (reverse (assoc-ref opts 'script-args)))) + + (unless (null? script-args) + ;; Run script + (save-module-excursion + (lambda () + (set-program-arguments script-args) + (set-user-module) + (load (car script-args))))) + + (when (null? script-args) + ;; Start REPL + (let ((type (assoc-ref opts 'type))) + (call-with-connection (assoc-ref opts 'listen) + (lambda () + (case type + ((guile) + (save-module-excursion + (lambda () + (set-user-module) + ;; Do not exit repl on SIGINT. + ((@@ (ice-9 top-repl) call-with-sigint) + (lambda () + (start-repl)))))) + ((machine) + (machine-repl)) + (else + (leave (G_ "~a: unknown type of REPL~%") type))))))))) + + ;; Local Variables: + ;; eval: (put 'call-with-connection 'scheme-indent-function 1) + ;; End: + ) diff --git a/tests/guix-repl.sh b/tests/guix-repl.sh new file mode 100644 index 0000000000..78b775baf3 --- /dev/null +++ b/tests/guix-repl.sh @@ -0,0 +1,78 @@ +# GNU Guix --- Functional package management for GNU +# Copyright =C2=A9 2020 Simon Tournier +# Copyright =C2=A9 2020 Konrad Hinsen +# +# This file is part of GNU Guix. +# +# GNU Guix is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or (at +# your option) any later version. +# +# GNU Guix is distributed in the hope that it will be useful, but +# WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with GNU Guix. If not, see . + +# +# Test the `guix repl' command-line utility. +# + +guix repl --version + +test_directory=3D"`mktemp -d`" +export test_directory +trap 'chmod -Rf +w "$test_directory"; rm -rf "$test_directory"' EXIT + +tmpfile=3D"$test_directory/foo.scm" +rm -f "$tmpfile" +trap 'rm -f "$tmpfile"' EXIT + +module_dir=3D"t-guix-repl-$$" +mkdir "$module_dir" +trap 'rm -rf "$module_dir"' EXIT + + +cat > "$tmpfile"< "$module_dir/foo.scm"< "$tmpfile"< "$tmpfile"<