From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id QBWuBjxV7WPlTAEAbAwnHQ (envelope-from ) for ; Wed, 15 Feb 2023 22:57:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id OLGwBjxV7WPKagEA9RJhRA (envelope-from ) for ; Wed, 15 Feb 2023 22:57:16 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B6E3A2B854 for ; Wed, 15 Feb 2023 22:57:15 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSPlx-0000cy-Fd; Wed, 15 Feb 2023 16:57:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSPlv-0000cW-FT for guix-patches@gnu.org; Wed, 15 Feb 2023 16:57:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSPlv-0006B1-1N for guix-patches@gnu.org; Wed, 15 Feb 2023 16:57:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pSPlu-0006gO-Dc for guix-patches@gnu.org; Wed, 15 Feb 2023 16:57:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60386] [PATCH] gnu: Add guile-proba. Resent-From: Luis Felipe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 15 Feb 2023 21:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60386 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jelle Licht Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 60386@debbugs.gnu.org Received: via spool by 60386-submit@debbugs.gnu.org id=B60386.167649818725642 (code B ref 60386); Wed, 15 Feb 2023 21:57:02 +0000 Received: (at 60386) by debbugs.gnu.org; 15 Feb 2023 21:56:27 +0000 Received: from localhost ([127.0.0.1]:34169 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSPlK-0006fW-Gd for submit@debbugs.gnu.org; Wed, 15 Feb 2023 16:56:26 -0500 Received: from mail-40130.protonmail.ch ([185.70.40.130]:54011) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSPlH-0006fH-Oo for 60386@debbugs.gnu.org; Wed, 15 Feb 2023 16:56:24 -0500 Date: Wed, 15 Feb 2023 21:56:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1676498176; x=1676757376; bh=YU9sIIAj4er1zgz0Up+/IXdtrNrdWSiTw/wK0kTvGFI=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=p0kjZaQXHWQFLUXrFPtUvoz+a1cNvjCmjE/87mqaP6wObw/WIHWSCbTbbbJ9CWCaz v3I+WpB6CU3DqMjlz/Fm7xDh7vIvl6IIW5/MtmQwj+GR7P+hHqrLKVfSYXtv3MrVOb wMfA590S/ZO4Aadm9lv6YV1O1RBNviWUzRfjmTNrAZUckhVbozaBkq1vpxbMhPY7fY FVDy4aYMOWMpnuyCFeWuQtZ96NRZghxIJ37+NNOtrZiBx17l9nqJCxQAg2EEZqH4d4 m/Kr06sZRnu8OAA/DXAjyUgqVpziSCKIZF6JS3Z36Z0v4RVxRQpFHT8kw1ltb2U0QZ NnoFL2xlBXfWA== Message-ID: In-Reply-To: <87pmadr86d.fsf@fsfe.org> References: <87edrti82j.fsf@gnu.org> <0R2fGew0iuJD4YBAaHVjCshZMF52BTBE0WeK7DfiPAO5ebcSRE6PWiix30uJUY35OigiDykEQF_ZpjNc18IoQatNgRXsz4_cx6oMriFDo8M=@protonmail.com> <87wn5cyjkw.fsf@gnu.org> <_jbPEie6ho5J8_1hgP63VBuPhumFn1hAzjkWOv0rD7BwHVYo7ZgAa7UAxkuXNRxGvPBwbz6xNBQ2S2TZMwbDnme8JVwnDqtwElWisSfBr8E=@protonmail.com> <87sffxr63g.fsf_-_@gnu.org> <87pmadr86d.fsf@fsfe.org> Feedback-ID: 24022468:user:proton MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha256; boundary="------80e118d38009c21fd3efc16973f4945139f2995f59b706cebbb1e31cc24aee53"; charset=utf-8 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Luis Felipe X-ACL-Warn: , Luis Felipe via Guix-patches From: Luis Felipe via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1676498235; a=rsa-sha256; cv=none; b=bj7amq+Vo6HdPMe+jdQzpPv/pfew34XJLyd5TGrbtYCdZUq4J1WECruo1LIPNXoNaQwjjG QcrbopJLjoOcDevT8qrjIcrzblL5tYcGHaJEdX9+/FqdXF4xX8kkkcH5FmXGv9fYGPe+56 AwTHlPf4IvDNasQE87Zm8ik3upslYGVzxt5Th50nBSiKy5iQnJ5uPGe+e1vrdFF8Vcrt1v vSFm0EHgR2pgCCFIGfQIRr8qbVcmWbnXpWQq3zHHZDMF3rh+8JhULjDLPb+9sjA19D+Cyg PMPKkays347yukSJ+Zr1JA3Q0d9d2XA8jxDBja75MOQobkw02AbudrReQhUpzg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=p0kjZaQX; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676498235; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=YU9sIIAj4er1zgz0Up+/IXdtrNrdWSiTw/wK0kTvGFI=; b=Nwc9kunbZD9lsjXqvHQLOXg3YzzIN1voiNDgBJibAoiPNXJjSa9mCJhA7rOkiFJfyJiVFP G+kivsI40VoBEaU/Emn2UFr1XRW2EoTWE2Ilnn3J9LkeVB8FqsDZYhGq6xU6HyXcgEGkw8 p4FXmGoF+nITgn9hPE0WnLc4taitt/R+/DF8a1cRSa8bL7WZpJDkCQD5t5ACHNApSeYoVg iiEaEzFlyMJL1Pz8Vkp2bhGi0wUKw2RKDu1H4PxMLH3WAjQl7EaEBcGDxhgQ9jmbTjidYm UF+xQOx6dUCRVp3i+9u11/SHAXgswj/h+0BQxX0h9mrA5DXR3eu9SemRK+SXOQ== X-Spam-Score: -5.62 X-Migadu-Queue-Id: B6E3A2B854 X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -5.62 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=p0kjZaQX; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-TUID: LGzhbIlv0BnO This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------80e118d38009c21fd3efc16973f4945139f2995f59b706cebbb1e31cc24aee53 Content-Type: multipart/mixed;boundary=---------------------04a18d3e24d1d41b53acac7d28804d4f -----------------------04a18d3e24d1d41b53acac7d28804d4f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain;charset=utf-8 Hi Jelle, thanks for taking a look. I'm sending a new patch after this message, but I'm replying to your revie= w below. On Monday, February 13th, 2023 at 13:44, Jelle Licht wro= te: > > + (native-inputs (list guile-3.0 texinfo)) > = > = > I think guile should be a normal input. Other packages like this > (e.g. guilescript, ccwl) seem to do it that way. I moved it to inputs now. But I placed it in native-inputs following the g= uile-build-system documentation in the manual: "Packages built with =E2=80=98guile-build-system=E2=80=99 must provide a G= uile package in their =E2=80=98native-inputs=E2=80=99 field." Did I misunderstand or should that part of the manual be updated? > > + (propagated-inputs (list guile-config guile-lib)) > > + (arguments > > + (list > > + #:phases > > + #~(modify-phases %standard-phases > > + (add-after 'build 'check > > + (lambda _ > > + (invoke "guile" "proba.scm" "run" "tests"))) > > + (add-after 'install 'install-wrapped-script > > + (lambda* (#:key outputs #:allow-other-keys) > > + (let* ((out (assoc-ref outputs "out")) > > + (version (target-guile-effective-version)) > > + (scm (string-append "/share/guile/site/" version)) > > + (go (string-append "/lib/guile/" version "/site-ccache")) > > + (bin-dir (string-append out "/bin")) > > + (script (string-append bin-dir "/proba"))) > > + (mkdir-p bin-dir) > > + (copy-file "proba.scm" script) > > + (chmod script #o555) > > + (wrap-program script > > + `("GUILE_LOAD_PATH" prefix + (,(string-append out scm))) +` ("GUILE_= LOAD_COMPILED_PATH" prefix > > + (,(string-append out go))))))) > = > = > This seems almost correct, as it extends the GUILE_LOAD_{,COMPILED}PATH > at runtime; the user would for still need to have the guile-config and > guile in their profile. Although guile-config is also listed as a > propagated input, when the guile search paths specifications are not > active, the following would not work: > = > `guix shell --pure guile-proba -- proba run tests' > = > You could have a look at the 'wrap phase of the ccwl package; they use > the value of (getenv "GUILE_LOAD{,COMPILED}_PATH") retrieved while > building the package to wrap their script. I added a new phase to set Guile load paths so that they take (getenv "GUI= LE_LOAD{,COMPILED}_PATH") into account, and modified the wrapping accordin= gly. In my test, running "guix shell --pure guile-proba -- proba run tests= " works now. > > + (add-after 'install 'install-manual > > + (lambda* (#:key outputs #:allow-other-keys) > > + (let* ((out (assoc-ref outputs "out")) > > + (info-dir (string-append out "/share/info"))) > > + (mkdir-p info-dir) > > + (invoke "makeinfo" "manual/main.texi") > > + (install-file "guile-proba" info-dir))))) > = > Nitpick, so feel free to ignore: > You could split up building and installing the manual. I put building into a separate phase. > > + #:not-compiled-file-regexp > > + "((bogus|bogus-tests|packages|tests)\\/.*.scm|(proba|manifest).scm)$= ")) > = > = > All of the files listed in this regex are still installed in > /share/guile/site/3.0. Do you think it would be possible to ensure > these files are not installed? It was possible. Now it looks like this: /gnu/store/xaqmf7n83h5dq9xv6is46ybjk98ssakr-guile-proba-0.3.0 |-- bin | `-- proba |-- lib | `-- guile | `-- 3.0 | `-- site-ccache | `-- proba | |-- cli.go | |-- commands.go | |-- runners.go | |-- templates.go | `-- utils.go `-- share |-- doc | `-- guile-proba-0.3.0 | |-- README.org | `-- index.html |-- guile | `-- site | `-- 3.0 | `-- proba | |-- cli.scm | |-- commands.scm | |-- runners.scm | |-- templates.scm | `-- utils.scm `-- info `-- guile-proba -----------------------04a18d3e24d1d41b53acac7d28804d4f Content-Type: application/pgp-keys; filename="publickey - luis.felipe.la@protonmail.com - 0x12DE1598.asc"; name="publickey - luis.felipe.la@protonmail.com - 0x12DE1598.asc" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="publickey - luis.felipe.la@protonmail.com - 0x12DE1598.asc"; name="publickey - luis.felipe.la@protonmail.com - 0x12DE1598.asc" LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tCgp4c0JOQkY4WnBVZ0JDQURMamgy dW0ySmRsOUJRS2tnTVNnbkhKK3NIaDdLei92UDlzd3E3SFlMRW5GZzYKSEI0S2t1b1dJcU15RUpy TmM0azVSUEhieGs5cUEwemtBMXdBOHh2M2pBKzJVbGlRa2taUjArNHI5Syt4CmZZRGx4ZHd2Sk1V RVJaUk5kb3QvZnFCaGtTYmhpVElTU3pvRUs2ZjNreHdiN3NyME9jSkx2aU5wQ0tvawpZWjVGdzRR endDRjlXWGNrRWY5c0V4Y0ZjNkNOR0svSkJWVlpmVmhxVk1reGpRTjZicXVZbnprcThZU2gKOWdZ UzlYMXZsYmRSQXllS1JhcTR1akl1dGlTNnYwMmw0UkU2dUY1amlyOHgvVHg3NzRGbmpQQjZnQ3Vs Ck5TeDZCZmhVTndZeWJ5UFB4SVhYOUpPNHZrT3ZXNE9NZVdjcW1BK1VnQ3c5Vmk5dnJDN3lISlRG QUJFQgpBQUhOUFd4MWFYTXVabVZzYVhCbExteGhRSEJ5YjNSdmJtMWhhV3d1WTI5dElEeHNkV2x6 TG1abGJHbHcKWlM1c1lVQndjbTkwYjI1dFlXbHNMbU52YlQ3Q3dIWUVFQUVJQUNBRkFsOFpwVWdH Q3drSENBTUNCQlVJCkNnSUVGZ0lCQUFJWkFRSWJBd0llQVFBS0NSQTU0TWRqZWpuR3FWVWFCLzk3 UC9WSEtwK0FiRWJMemVkNgpQSWhIcjY0ZDh6Tk83bWJsbkZ3Tno0OWhrN0ptUllMNXZQMlYvbUMw M1dJSmZTaml2WUdTaUhuTFJlREUKbmxtVUNNZjNtKzFOOThlQWlxSE5FZzZlaWkzMmFxVlFiYXh2 L3orNTlSR2VLSDJBbHRhZHBzVEFnS1VzCjFrL2Z0ZEJXVlplYitCQXJHYWlsREU3OHVlYiszWE15 Z3ZDV2oyMWZleS81VXZiakhxUjlMNEpZVGlTbQp3WXo3SGZabytERTdZSXNjem1WZWg4TTFWekNs LzFpYWhrOVVFTGpBUC9qUCtydU1UOXFFV3VqMlFsbEEKTWVQR1J6UWJxaURoVlM4TEZkakJITm9L THh5aG5iREVGakhGLzR4TnE4amxRTGZHSlo1aEtldHRaK2JVClNXYUVYRjNoano5V1dVOGE1Sy8y TS9Ib3pzQk5CRjhacFVnQkNBREtVblJJOXl6NFJ2TnV2U09JRmxKdgprZm9IZVpyL0JMY1NHVmNT Qmt4NWxzS2RWek14OStVYWFlS2pXcElPK3hmRU5zejdiK0JWb0JMMFdydjkKNGhsd1dtRzVxMEFk RXlVMS9mUXNSUjdtNU8xZWE2VVQzZnVVZzFWc2pGWitSM2pTeWxBdHl6SVpNMExVCmJXNUY2NzNL NEF1U2NGcE44TkxHVGdScjBXUWwvQm5Id2gyWFExeHFoYzZHQk92d2l3VkJqYWY1MFNIRQpUaVVQ cGUzSmpReXlCWnArOEZLbStzblJxQ0dYbjBKRzhvMEZYeTlXY3h0dmZRRk1NSnA5Qk8yeXRneEgK elFJcFljSnBKWnVjY25Gb3FxSDlqKzFxWFhOU2EzL3FPM3p1OWxTdlhUeHg2a2RoMEZXVG5ZQ3g4 TWY4CkJZL1BXL2JCT095aExDb1RrSHFsQUJFQkFBSEN3RjhFR0FFSUFBa0ZBbDhacFVnQ0d3d0FD Z2tRT2VESApZM281eHFrZUtRZitKTWxjYlJsd2VoL0ZBMW53OHpGQ3hhRjU4UE5ERU84bEg5Mi94 dHpud0dkQXVselQKaFo0MGpHVEVpcHlnc25xSFY3V0hVZjQ0bmVYbjJBMWN2Q1orNzNLY3BhUU5o OU1wOHlXbkdLWllVR2tHCjZPZjFoRVU3OTJYWkV4a3lBODJQZ0xCTlkrVnpOWFhLQ0g3Tlh4WlFR V1Y1blhjYlVGQ1p5Slp1ZFNnUQp4azE5c1FmNHM5dkpYNlBDNjhxd2k3YUoxN25WZnJiY01heVJw bTJPR0pYZCt0OTFWL0xuTnBDUmd0bDMKak5Zc0NCRktEQzBZeGRBL05DZEVrMWdmdWpGemwwYkJz Nys1SmJkM3pSYUU1QWZkVlF0SWxtRVhEa1c2CjB1eUVpM050Y3E1b2RYQTFubFIrZTA0NEtGdmVa ekZ1Tk5lVGdzekFCcjVIaVU3MC9FbHlzdz09Cj16NmU3Ci0tLS0tRU5EIFBHUCBQVUJMSUMgS0VZ IEJMT0NLLS0tLS0K -----------------------04a18d3e24d1d41b53acac7d28804d4f-- --------80e118d38009c21fd3efc16973f4945139f2995f59b706cebbb1e31cc24aee53 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: ProtonMail wsBzBAEBCAAnBQJj7VTlCRA54MdjejnGqRYhBBLeFZh9HEWkNPdw7zngx2N6 OcapAAAobggAgYMc56bCPpRs9QutVmch7S0BkMuqnAX2xzv8mk9WOkTzD23U ocAFogdzFvnHu/fe4c2fY1RWl95PQ59Qe5GwS7CE3nB+AzEQwCnDEoMaXI3G rvSwdKOu6SGXQjhQL38SMOb//ldBqCg0A0AxtvW07WU8AwH58JEHZuYdBhjf afAkbZgKp8Y4iItgz9G2I71LLgjxU8rqxrqtjynzSYhT2uy2768oVXu9740p BryDkY/prttrVvSWZoXqAAEp0BYiEDJRaXsdZW8YAKz3EwPQNLr83wFJnI/j mjelerq7jyRWUxE54a0MeKOvU5/pGkWqvBWrH9HYOR5KnbnrRzZO/g== =bb9u -----END PGP SIGNATURE----- --------80e118d38009c21fd3efc16973f4945139f2995f59b706cebbb1e31cc24aee53--