From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH 04/10] gnu: Add python-keystoneclient. Date: Fri, 11 Dec 2015 15:15:35 +0100 Message-ID: References: <1449153811-32039-1-git-send-email-efraim@flashner.co.il> <1449153811-32039-5-git-send-email-efraim@flashner.co.il> <20151207212658.06ad1a0c@debian-netbook> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7OU7-0005Dp-RQ for guix-devel@gnu.org; Fri, 11 Dec 2015 09:15:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a7OU4-0001Nt-KW for guix-devel@gnu.org; Fri, 11 Dec 2015 09:15:47 -0500 Received: from pegasus.bbbm.mdc-berlin.de ([141.80.25.20]:58385) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7OU3-0001Np-Up for guix-devel@gnu.org; Fri, 11 Dec 2015 09:15:44 -0500 In-Reply-To: <20151207212658.06ad1a0c@debian-netbook> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Efraim Flashner Cc: guix-devel@gnu.org Efraim Flashner writes: > From 6837ac485125476040469289072e6f59a7139939 Mon Sep 17 00:00:00 2001 > From: Efraim Flashner > Date: Mon, 23 Nov 2015 20:29:12 +0200 > Subject: [PATCH 04/10] gnu: Add python-keystoneclient. > * gnu/packages/openstack.scm (python-keystoneclient) > (python2-keystoneclient): New variables. > --- > gnu/packages/openstack.scm | 73 ++++++++++++++++++++++++++++++++++++++= +++++++- > 1 file changed, 72 insertions(+), 1 deletion(-) > diff --git a/gnu/packages/openstack.scm b/gnu/packages/openstack.scm > index 2578292..43f957b 100644 > --- a/gnu/packages/openstack.scm > +++ b/gnu/packages/openstack.scm > @@ -19,12 +19,14 @@ =20 > (define-module (gnu packages openstack) > #:use-module (gnu packages python) > + #:use-module (gnu packages tls) > #:use-module (gnu packages version-control) > #:use-module (guix build-system python) > #:use-module (guix download) > #:use-module ((guix licenses) > #:select (asl2.0)) > - #:use-module (guix packages)) > + #:use-module (guix packages) > + #:use-module (srfi srfi-1)) =20 > (define-public python-bandit > (package > @@ -679,3 +681,72 @@ handling.") =20 > (define-public python2-oslo.utils > (package-with-python2 python-oslo.utils)) > + > +(define-public python-keystoneclient > + (package > + (name "python-keystoneclient") > + (version "1.8.1") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "python-keystoneclient" version)) > + (sha256 > + (base32 > + "1w4csvkah67rfpxylxnvs2s3594i0f9isy8pf4gnsqs5zirvjaa4")))) The indentation is a bit off. If this was the only thing I could fix this before pushing, but I still have some other comments. > + (build-system python-build-system) > + (native-inputs > + `(("python-setuptools" ,python-setuptools) > + ;; and some packages for the tests > + ("openssl" ,openssl) > + ("python-coverage" ,python-coverage) > + ("python-discover" ,python-discover) > + ("python-fixtures" ,python-fixtures) > + ("python-hacking" ,python-hacking) > + ("python-keyring" ,python-keyring) > + ("python-lxml" ,python-lxml) > + ("python-mock" ,python-mock) > + ("python-mox3" ,python-mox3) > + ("python-oauthlib" ,python-oauthlib) > + ("python-oslosphinx" ,python-oslosphinx) > + ("python-oslotest" ,python-oslotest) > + ("python-pycrypto" ,python-pycrypto) > + ("python-requests-mock" ,python-requests-mock) > + ("python-sphinx" ,python-sphinx) This doesn=E2=80=99t look like it=E2=80=99s needed for the tests. Maybe = you could move it above the comment (or remove the comment)? > + ("python-temptest-lib" ,python-tempest-lib) > + ("python-testrepository" ,python-testrepository) > + ("python-testresources" ,python-testresources) > + ("python-testtools" ,python-testtools) > + ("python-webob" ,python-webob))) Wow! That=E2=80=99s a very long list of test dependencies. Thanks for y= our patience in tracking them down rather than taking the easy route of disabling tests! > + (propagated-inputs > + `(("python-babel" ,python-babel) > + ("python-debtcollector" ,python-debtcollector) > + ("python-iso8601" ,python-iso8601) > + ("python-netaddr" ,python-netaddr) > + ("python-oslo.config" ,python-oslo.config) > + ("python-oslo.i18n" ,python-oslo.i18n) > + ("python-oslo.serialization" ,python-oslo.serialization) > + ("python-oslo.utils" ,python-oslo.utils) > + ("python-pbr" ,python-pbr) > + ("python-prettytable" ,python-prettytable) > + ("python-requests" ,python-requests) > + ("python-six" ,python-six) > + ("python-stevedore" ,python-stevedore))) > + (home-page "http://www.openstack.org/") > + (synopsis "Client Library for OpenStack Identity") > + (description > + "Python-keystoneclient is the identity service used by OpenStack fo= r > +authentication (authN) and high-level authorization (authZ). It curre= ntly > +supports token-based authN with user/service authZ, and is scalable to= support > +OAuth, SAML, and OpenID in future versions. Out of the box, Keystone = uses > +SQLite for its identity store database, with the option to connect to = external > +LDAP.") I wonder: if it does uses Sqlite by default, how come sqlite is not among the inputs? Does it bundle sqlite sources? Or does it just fail by default unless sqlite is installed? > + (license asl2.0))) > + > +(define-public python2-keystoneclient > + (let ((keystoneclient (package-with-python2 python-keystoneclient))) > + (package (inherit keystoneclient) > + (native-inputs > + `(("python2-oauthlib" ,python2-oauthlib) > + ,@(alist-delete > + "python-oauthlib" > + (package-native-inputs keystoneclient))))))) Okay! ~~ Ricardo