From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: Update mafft to 7.245.
Date: Tue, 10 Nov 2015 14:06:18 +0100
Message-ID: <idjy4e6c8c5.fsf@bimsb-sys02.mdc-berlin.net>
References: <5641E082.90801@uq.edu.au>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36150)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1Zw8dA-000610-SZ
	for guix-devel@gnu.org; Tue, 10 Nov 2015 08:06:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1Zw8d5-0002Ki-Lt
	for guix-devel@gnu.org; Tue, 10 Nov 2015 08:06:36 -0500
Received: from sinope.bbbm.mdc-berlin.de ([141.80.25.23]:59252)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1Zw8d5-0002Ip-CX
	for guix-devel@gnu.org; Tue, 10 Nov 2015 08:06:31 -0500
In-Reply-To: <5641E082.90801@uq.edu.au>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>


Ben Woodcroft <b.woodcroft@uq.edu.au> writes:

> Also had to fix the inputs.

In this case, please also mention these input changes in the commit
message.

>           (delete 'configure))))
> -    (inputs
> -     `(("perl" ,perl)))
> +    (propagated-inputs
> +     `(("perl" ,perl)
> +       ("gawk" ,gawk)
> +       ("coreutils" ,coreutils)
> +       ("grep" ,grep)))

Is it really necessary to propagate these inputs?  Or could mafft just
reference them by their full path?  It=E2=80=99s very inelegant to propag=
ate
packages.

In the case of coreutils I=E2=80=99m not sure if this is needed at all.  =
Instead
of propagating these inputs I=E2=80=99d suggest adding a phase that patch=
es the
sources with =E2=80=98(substitute* ...)=E2=80=99 such that any call to aw=
k, grep, perl,
or the coreutils is prefixed with the full store path.

Then you don=E2=80=99t need to propagate inputs and users won=E2=80=99t r=
un into
conflicts.

~~ Ricardo