all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: Update mafft to 7.245.
Date: Tue, 10 Nov 2015 14:06:18 +0100	[thread overview]
Message-ID: <idjy4e6c8c5.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <5641E082.90801@uq.edu.au>


Ben Woodcroft <b.woodcroft@uq.edu.au> writes:

> Also had to fix the inputs.

In this case, please also mention these input changes in the commit
message.

>           (delete 'configure))))
> -    (inputs
> -     `(("perl" ,perl)))
> +    (propagated-inputs
> +     `(("perl" ,perl)
> +       ("gawk" ,gawk)
> +       ("coreutils" ,coreutils)
> +       ("grep" ,grep)))

Is it really necessary to propagate these inputs?  Or could mafft just
reference them by their full path?  It’s very inelegant to propagate
packages.

In the case of coreutils I’m not sure if this is needed at all.  Instead
of propagating these inputs I’d suggest adding a phase that patches the
sources with ‘(substitute* ...)’ such that any call to awk, grep, perl,
or the coreutils is prefixed with the full store path.

Then you don’t need to propagate inputs and users won’t run into
conflicts.

~~ Ricardo

  reply	other threads:[~2015-11-10 13:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-10 12:18 Update mafft to 7.245 Ben Woodcroft
2015-11-10 13:06 ` Ricardo Wurmus [this message]
2015-11-10 13:12 ` Efraim Flashner
2015-11-10 22:22   ` Ben Woodcroft
2015-12-10 16:16     ` Ricardo Wurmus
2015-12-15 12:05       ` Ben Woodcroft
2015-12-17 12:47         ` Ricardo Wurmus
2015-12-17 20:01           ` Ben Woodcroft
2015-12-17 22:29             ` Ricardo Wurmus
2015-12-17 23:27               ` Ben Woodcroft
2015-12-21 14:17                 ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=idjy4e6c8c5.fsf@bimsb-sys02.mdc-berlin.net \
    --to=ricardo.wurmus@mdc-berlin.de \
    --cc=b.woodcroft@uq.edu.au \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.