From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH 09/10] gnu: Add python-natsort. Date: Thu, 21 Apr 2016 17:09:01 +0200 Message-ID: References: <1461244921-7412-1-git-send-email-donttrustben@gmail.com> <1461244921-7412-10-git-send-email-donttrustben@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40700) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1atGEE-0004BI-Bm for Guix-devel@gnu.org; Thu, 21 Apr 2016 11:09:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1atGEA-0000Fx-1h for Guix-devel@gnu.org; Thu, 21 Apr 2016 11:09:14 -0400 Received: from venus.bbbm.mdc-berlin.de ([141.80.25.30]:42512) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1atGE9-0000Fl-Gx for Guix-devel@gnu.org; Thu, 21 Apr 2016 11:09:09 -0400 In-Reply-To: <1461244921-7412-10-git-send-email-donttrustben@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ben Woodcroft Cc: Guix-devel@gnu.org Ben Woodcroft writes: > * gnu/packages/python.scm (python-natsort, python2-natsort): New > variables. > --- > gnu/packages/python.scm | 44 +++++++++++++++++++++++++++++++++++++++++= +++ > 1 file changed, 44 insertions(+) > > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm > index ea9f47a..7aae6fc 100644 > --- a/gnu/packages/python.scm > +++ b/gnu/packages/python.scm > @@ -8901,6 +8901,50 @@ The same is true of requests in terms of caching= .") > (inherit base) > (native-inputs `(("python2-setuptools" ,python2-setuptools)))))) > =20 > +(define-public python-natsort > + (package > + (name "python-natsort") > + (version "4.0.4") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "https://pypi.python.org/packages/source/n/natsort/natsor= t-" > + version > + ".tar.gz")) Could you use =E2=80=9C(pypi-uri "natsort" version)=E2=80=9D instead? > + (sha256 > + (base32 > + "0f8q66pyczgy1cm3nh8rkh7hgl9h49zx9r06mivg4y5sbzla6sy7")))) > + (build-system python-build-system) > + (native-inputs > + `(("python-pytest" ,python-pytest) > + ("python-pytest-flakes" ,python-pytest-flakes) > + ("python-pytest-cov" ,python-pytest-cov) > + ("python-pytest-cache" ,python-pytest-cache) > + ("python-hypothesis" ,python-hypothesis) > + ("python-pytest-pep8", python-pytest-pep8))) > + (home-page "https://github.com/SethMMorton/natsort") > + (synopsis "Sort lists naturally") > + (description "When you try to sort a list of strings that contain = numbers, > +the normal python sort algorithm sorts lexicographically, so you might= not get > +the results that you expect. @code{natsort} provides a function > +@code{natsorted} that helps sort lists 'naturally', either as real > +numbers (i.e. signed/unsigned floats or ints), or as versions.") > + (license license:expat) > + (properties `((python2-variant . ,(delay python2-natsort)))))) > + > +(define-public python2-natsort > + (let ((base (package-with-python2 > + (strip-python2-variant python-natsort)))) > + (package > + (inherit base) > + (native-inputs > + (append (package-native-inputs base) > + `(("python2-mock" ,python2-mock) > + ("python2-pathlib" ,python2-pathlib) > + ("python2-enum34" ,python2-enum34) > + ("python2-setuptools" ,python2-setuptools))))))) > + > (define-public python-cysignals > (package > (name "python-cysignals") The rest looks fine to me. ~~ Ricardo