From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH] R build system and CRAN importer (updated)
Date: Mon, 31 Aug 2015 16:29:27 +0200
Message-ID: <idjwpwb8raw.fsf@bimsb-sys02.mdc-berlin.net>
References: <idjr3no8o9s.fsf@bimsb-sys02.mdc-berlin.net>
	<idjwpwyb6px.fsf@bimsb-sys02.mdc-berlin.net>
	<CAJ=RwfatZX7nGsS8T6dDsSzjrkX7gX7=rj-tDQxVDQ4ASz_Qag@mail.gmail.com>
	<idjr3msahnd.fsf@bimsb-sys02.mdc-berlin.net>
	<idjlhcy9grk.fsf@bimsb-sys02.mdc-berlin.net>
	<87613xokyv.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38941)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1ZWQ5d-0005ym-5A
	for guix-devel@gnu.org; Mon, 31 Aug 2015 10:29:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1ZWQ5Y-0004s6-2d
	for guix-devel@gnu.org; Mon, 31 Aug 2015 10:29:41 -0400
In-Reply-To: <87613xokyv.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>


Ludovic Court=C3=A8s <ludo@gnu.org> writes:

> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
>
>> From 1c726be7746021f5d967d12154c057391e24585d Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
>> Date: Fri, 24 Jul 2015 16:49:57 +0200
>> Subject: [PATCH 1/2] import: Add 'cran' importer.
>>
>> * guix/import/cran.scm: New file.
>> * guix/scripts/import.scm: Add "cran" to 'importers'.
>> * guix/scripts/import/cran.scm: New file.
>> * tests/cran.scm: New file.
>> * Makefile.am (MODULES): Add 'guix/import/cran.scm' and
>>   'guix/scripts/import/cran.scm'.
>>   (SCM_TESTS): Add 'tests/cran.scm'.
>> * doc/guix.texi (Invoking guix import): Document it.
>> * po/guix/POTFILES.in: Add 'guix/scripts/import/cran.scm'.

[...]

> Otherwise LGTM.  OK to push with these changes.

Pushed with all suggested changes.

>> From 8271e8a5e7d237693e8d4b7b34e4a484b9a1fc22 Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
>> Date: Fri, 31 Jul 2015 14:47:34 +0200
>> Subject: [PATCH 2/2] build: Add R build system.
>>
>> * guix/build-system/r.scm: New file.
>> * guix/build/r-build-system: New file.
>> * Makefile.am (MODULES): Add new files.
>> * doc/guix.texi (Build Systems): Document r-build-system.
>
> [...]
>
>> +(define (call-r command params)
>
> Nitpick: I=E2=80=99d call it =E2=80=98invoke-r=E2=80=99 (a function is =
called, a program is
> invoked.)

Changed to =E2=80=98invoke-r=E2=80=99 and pushed.

Thanks!

~~ Ricardo